Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mypy issue in VideoClips #8113

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fixed mypy issue in VideoClips #8113

merged 1 commit into from
Nov 13, 2023

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Nov 13, 2023 •
edited
Loading

Fixing CI error: https://github.com/pytorch/vision/actions/runs/6826668235/job/18620326828?pr=8110

  torchvision/datasets/video_utils.py:139: error: Need type annotation for
  "video_fps" (hint: "video_fps: List[<type>] = ...")  [var-annotated]
              self.video_fps = []
              ^~~~~~~~~~~~~~
  Found 1 error in 1 file (checked 236 source files)

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 13, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8113

Note: Links to docs will display an error until the docs builds have been completed.

❌ 25 New Failures, 10 Unrelated Failures

As of commit 5ffcbf2 with merge base 15c166a (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vfdev-5 vfdev-5 force-pushed the fix-mypy-issue-videoclips branch from 7291466 to 5ffcbf2 Compare November 13, 2023 12:01
@vfdev-5 vfdev-5 requested a review from pmeier November 13, 2023 12:02
pmeier
pmeier approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pmeier pmeier merged commit 517f6d3 into pytorch:main Nov 13, 2023
28 of 62 checks passed
@github-actions GitHub Actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier added the other if you have no clue or if you will manually handle the PR in the release notes label Nov 13, 2023
@vfdev-5 vfdev-5 deleted the fix-mypy-issue-videoclips branch November 13, 2023 12:23
facebook-github-bot pushed a commit that referenced this pull request Nov 16, 2023
@NicolasHug @facebook-github-bot
[fbsync] Fixed mypy issue in VideoClips (#8113)
0f588e4 
Reviewed By: vmoens

Differential Revision: D51391971

fbshipit-source-id: 2df538eaa3abab2f37ff271208a160906d80e9e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vfdev-5 @pmeier @facebook-github-bot