Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow size to be generic Sequence #7999

Merged
merged 5 commits into from
Sep 28, 2023
Merged

allow size to be generic Sequence #7999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d09c981
allow size to be generic Sequence
wangg12 Sep 28, 2023
6dca625
Update torchvision/transforms/v2/_geometry.py
NicolasHug Sep 28, 2023
84080a2
Merge branch 'main' into patch-1
NicolasHug Sep 28, 2023
0e77079
Fix error message
NicolasHug Sep 28, 2023
0fd300c
Merge branch 'main' into patch-1
NicolasHug Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/test_transforms_v2_refactored.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ def test_interpolation_int(self, interpolation, make_input):
assert_equal(actual, expected)

def test_transform_unknown_size_error(self):
with pytest.raises(ValueError, match="size can either be an integer or a list or tuple of one or two integers"):
with pytest.raises(ValueError, match="size can either be an integer or a sequence of one or two integers"):
transforms.Resize(size=object())

@pytest.mark.parametrize(
Expand Down
4 changes: 2 additions & 2 deletions torchvision/transforms/v2/_geometry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,11 @@ def __init__(

if isinstance(size, int):
size = [size]
elif isinstance(size, (list, tuple)) and len(size) in {1, 2}:
elif isinstance(size, Sequence) and len(size) in {1, 2}:
size = list(size)
else:
raise ValueError(
f"size can either be an integer or a list or tuple of one or two integers, " f"but got {size} instead."
f"size can either be an integer or a sequence of one or two integers, but got {size} instead."
)
self.size = size

Expand Down