Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace c10::stoi with std::stoi #7966

Merged
merged 1 commit into from
Sep 18, 2023
Merged

replace c10::stoi with std::stoi #7966

merged 1 commit into from
Sep 18, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Sep 18, 2023

c10::stoi was removed in pytorch/pytorch#109179 in favor of std::stoi.

cc @cyyever

@pmeier pmeier requested a review from colesbury September 18, 2023 07:25
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 18, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7966

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 8cf35b6 with merge base 75046bd (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier pmeier mentioned this pull request Sep 18, 2023
Closed
@cyyever
Copy link
Contributor

cyyever commented Sep 18, 2023 •
edited
Loading

@pmeier I also noticed the building error in torchvision, this fix should work. By the way, c10::to_string in this file should be replaced with std::to_string.

@pmeier
Copy link
Collaborator Author

pmeier commented Sep 18, 2023

@cyyever There is no c10::to_string in the file or in the whole codebase for that matter. Could you explain what you mean?

@cyyever
Copy link
Contributor

cyyever commented Sep 18, 2023

@cyyever There is no c10::to_string in the file or in the whole codebase for that matter. Could you explain what you mean?

Sorry, I made a mistake. No c10::to_string in the codebase.

vfdev-5
vfdev-5 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

@pmeier pmeier merged commit 4cb3d80 into pytorch:main Sep 18, 2023
59 of 63 checks passed
@pmeier pmeier deleted the stoi branch September 18, 2023 08:36
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2023
@NicolasHug @facebook-github-bot
[fbsync] replace c10::stoi with std::stoi (#7966)
14c59a4 
Reviewed By: matteobettini

Differential Revision: D49600772

fbshipit-source-id: d3b73fc1a1e5a1e81212bc4e0d16c9d17ddeedcf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

@colesbury colesbury Awaiting requested review from colesbury

Assignees
No one assigned
Labels
cla signed core issue module: video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmeier @cyyever @vfdev-5 @facebook-github-bot