-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin python version for cmake workflows #7060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @pmeier !
LGTM although LMK what you think on my comment below. I'll approve regardless so feel free to merge once you're happy with the solution
On Windows we are simply using the Python that is installed on the image, which is 3.7: https://app.circleci.com/pipelines/github/pytorch/vision/22531/workflows/dc22a930-661b-4431-b5bb-648e3d257c32/jobs/1804909?invite=true#step-103-77 I'm not going to touch this here, but whatever we set in vision/.circleci/regenerate.py Line 284 in 2b16299
is completely ignored for Windows. |
environment: | ||
PYTHON_VERSION: << parameters.python_version >> | ||
PYTORCH_VERSION: << parameters.pytorch_version >> | ||
UNICODE_ABI: << parameters.unicode_abi >> | ||
CU_VERSION: << parameters.cu_version >> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Driveby. We don't need these here, because they are pulled in at
Line 957 in 2b16299
<<: *binary_common |
from
Lines 222 to 226 in 2b16299
environment: | |
PYTHON_VERSION: << parameters.python_version >> | |
PYTORCH_VERSION: << parameters.pytorch_version >> | |
UNICODE_ABI: << parameters.unicode_abi >> | |
CU_VERSION: << parameters.cu_version >> |
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: * pin python version for macos cmake * ping python for all OS * revert to only set this for macos * debug * remove debug Reviewed By: YosuaMichael Differential Revision: D42500906 fbshipit-source-id: 06dc0b2d979a4b48ca0b6f76f1d58a53ee184ca9
On macOS, we are downloading Miniconda with
vision/.circleci/config.yml
Line 986 in 46b7e27
Until late Dec 2022 this included Python 3.9. From then on, the included Python version was 3.10 and our workflows started failing due to some unsatisfiable requirements.
Closes #7073