Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gaussian noise transform #6192 #6233
Add gaussian noise transform #6192 #6233
Changes from 21 commits
9be5e13
42952f6
db9756a
05a52af
c380281
431a7e0
5fc7c85
179908b
396abba
5d8b0f7
98e4e98
aa9b2e7
223074f
a26ed67
6d57443
1d1fbcd
ff80571
533e76f
b8d98d7
35ac3c9
42d49ae
74f92b1
54234f9
28fbd4b
6a95453
24804f6
b1bb81f
e08c9c1
7fc04aa
8a500fe
8b560fb
ac15585
3a85c34
5892695
e6b4e45
58d525d
021ecba
5956088
92d024f
bfde863
dbc3e1a
d18195b
a8d8137
2f7f558
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm bit hesitant about this implementation. Why not create
F.gaussian_noise
that would work well on PIL Images and tensors which we can then use here?See https://github.com/pytorch/vision/blob/main/torchvision/transforms/functional.py#L1338
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, let's create a functional op
F.gaussian_noise
and at first iteration we can have tensor implementation. If input is PIL, we can convert it to tensor, apply the op and get back PIL image type for the output.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parth-shastri please create a functional op
F.gaussian_noise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parth-shastri please address this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes working on that