-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add weight for mnasnet0_75 and mnasnet1_3 #6019
Add weight for mnasnet0_75 and mnasnet1_3 #6019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to change the default values for the weights in handle_legacy_interface
. Other than that it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @YosuaMichael!
The failed test seems to not related to this PR, will merge. |
Summary: * Add weight for mnasnet0_75 and mnasnet1_3 * Fix missing comma * Add PR url as recipe, and update the metrics * Add weights to legacy handler * Update docs to specify there are weights available Reviewed By: NicolasHug Differential Revision: D36760931 fbshipit-source-id: 00211a6dd22b4b42a9845b7b4d25337ed14a6349
Adding mnasnet0_75 and mnasnet1_3 weights.
Training commands:
Validation script: