Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ConvNeXt architecture in prototype #5197
Adding ConvNeXt architecture in prototype #5197
Changes from 21 commits
6682748
6c49ef8
a3034c4
e57b64f
8cddcac
6aedbcc
0bef112
cf69832
eb4c825
52960cf
8ddc17c
6dd11b7
ce05e24
c4ffc84
7af0e20
442a7bf
1ee5b0f
be2972e
f47a590
9e6fda1
daf07e0
2edbd8d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmarking necessary and potential rewrite to move out of prototype.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing f-string indication
f
nit: if you want to remove multiple assignments you can write something like
or if you rename input_channels to in_channels you can get everything in one line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a quite common pattern in TorchVision that I'm repeating here. See this. We could change in all instances perhaps on a separate issue?
Also good call for the
input_channels
vsin_channels
. Here I maintain it for consistency with other models such a shufflenets, mobilenetv3, efficientnets, vit etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Makes sense to leave it as it is now. I will create an issue to investigate if it makes sense to change everywhere.
I prefer using
fstrings
and explicitly use the variables we need but I can see that using this patter withs.format(**self.__dict__)
is quite generic