Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
masks_to_bounding_boxes
op #4290masks_to_bounding_boxes
op #4290Changes from all commits
cf51379
c67e035
3830dd1
926d444
f777416
cd46aa7
712131e
b6f5c42
b555c68
fc26f3a
c4d3045
4589951
6b19d67
c6c89ec
16a99a9
7115320
f4796d2
a070133
0131db3
0a23bcf
db8fb7b
f7a2c1e
c7dfcdf
5e6198a
7c78271
b9055c2
6c630c5
540c6a1
8e4fc2f
4c78297
140e429
8f2cd4a
7252723
26f68af
2c2d5dd
3a91957
e24805c
65404e9
6c89be7
b2a907c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial thought was dtype should be
torch.float
. Since all other ops follow float dtype.cc @datumbox @NicolasHug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, also the above zeros needs to have a device:
torch.zeros((0, 4), device=masks.device)
Could you please send a PR that fixes these 2 issues? The rest of the doc/test improvements discussed here can happen on a separate PR.