Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSD architecture with VGG16 backbone #3403
Add SSD architecture with VGG16 backbone #3403
Changes from all commits
db93f46
ebfd624
b2e42bb
6cfa98c
80da3b9
9779324
bffe4bc
eced9f0
869ede4
c5ba9c1
c91bfae
3820e09
044d178
6a7b9b4
e85e631
c574878
327e004
11c9839
34237e4
d3f345e
ac25158
c9c8148
eed06f4
69c4d24
b185e91
3a9166f
a604ab4
6e996d9
c524ee1
44d8a0b
15b3ebf
f67db92
d19144d
661eb31
dcdd04d
5a2e22c
5b5e8f8
6e04fb9
c709805
b3d40c4
2d0f267
39abfb4
0b7eb43
e74b4fe
3f0c99c
eb33940
c880de4
0883889
7c56cc8
218ca55
36f53f5
fe95322
67195c6
0342e7e
acdcd78
6c3b3fa
9ad0634
5a00a0c
0347c36
5661ac7
9e1da62
61482c6
dc5b7d5
82f8ddb
fc90ffa
2cbd58d
52940d4
db432f6
9f221ee
ff6ba4a
458d01e
84d81f4
88bd38f
fad5508
38e6e72
30de463
cdcbbcd
efebeb5
90e7b67
8ec186e
ebb7f90
92552de
9b4b2ce
6f0a61e
6ce9bd4
60c6f72
a818cc6
ff83c2d
2423a2a
017c634
3669795
20e5839
75f578b
0f581d3
3fb1e0b
1084847
57140bb
8942dd0
517c1da
2deb51e
937fde8
02a2af5
2befe43
a167edc
7c4d70d
a62d4e6
bc8063a
b2d5ec9
4760197
3dce96d
365d1ef
06477d6
6c94ff0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double-checked the logic and it seems good to me.
For the future, we might be able to avoid some of the excessive
continue
by more carefully selecting the sampling.For example, in the first block we can sample the aspect ratio in log-scale so that the aspect ration will be correct from the beginning, and then sample one value for the scale.
The same can be done for the crop (sampling so that none of the values are zero after rounding).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap, this can definitely be improved. I've implemented it straight as originally described and cross-referencing it with the original implementation to be sure as many similar implementations online are bugged. I would not touch this until there are proper unit-tests in place to ensure we maintain the same behaviour as this transform was crucial for hitting the accuracy reported on the paper.