Speedup Cmake builds #3186
Merged
Speedup Cmake builds #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
force-pushed
the
tests/speedup_cmake
branch
from
e18b7ec to
27edcc1
Compare
datumbox
force-pushed
the
tests/speedup_cmake
branch
from
cf4a080 to
34263bf
Compare
Merged
|
The failing tests are not related to this PR. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2021
Summary: * Speedup test_ucf101 (#2623 * Speedup Cmake builds (#3186) * Speedup test_autoaugment (#3190) * Speedup DeformConvTester (#3191) * Speedup InceptionV3 and GoogleNet on Windows (#3196) Reviewed By: datumbox Differential Revision: D25954568 fbshipit-source-id: bdcea84b112a9343f27619aef7036369598f631e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough improvement per platform:
Unlike Linux, MacOS and Windows do not have a separate step for setting up the Conda environment. Above I provide a rough estimation for it and I deduct it from the build times. I believe on Windows it's too close to call whether there is a substantial improvement.
The above are rough estimations based on a couple or runs.