Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move autograd implementations on separate files. #3154

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

datumbox
Copy link
Contributor

As discussed with @fmassa at #3146 (review) we are moving the autograd implementation on separate files.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mgoltzsche Max Goltzsche
@datumbox datumbox force-pushed the refactoring/separate_autograd_ops branch from 86ed25a to db2adb2 Compare December 10, 2020 20:50
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #3154 (db2adb2) into master (25e2085) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3154   +/-   ##
=======================================
  Coverage   72.75%   72.75%           
=======================================
  Files          99       99           
  Lines        8979     8979           
  Branches     1431     1431           
=======================================
  Hits         6533     6533           
  Misses       1999     1999           
  Partials      447      447           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a9c95...36464cd. Read the comment docs.

@datumbox datumbox requested a review from fmassa December 10, 2020 21:34
@datumbox datumbox mentioned this pull request Dec 10, 2020
5 tasks
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot!

@datumbox datumbox merged commit 0963ff7 into pytorch:master Dec 11, 2020
@datumbox datumbox deleted the refactoring/separate_autograd_ops branch December 12, 2020 11:17
facebook-github-bot pushed a commit that referenced this pull request Dec 15, 2020
Reviewed By: datumbox

Differential Revision: D25531038

fbshipit-source-id: 481434d15d0709417b3c36ff2b13e10a7994dff2
@datumbox datumbox mentioned this pull request Jan 5, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants