Fixing the upper bound limit of random pixels in tests to 256 #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
approved these changes
Dec 8, 2020
|
@vfdev-5 Most impactful PR of the entire release right there... 🤣 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 8, 2020
Reviewed By: datumbox Differential Revision: D25396708 fbshipit-source-id: 7aa27cd76f135c0ccca6b8412fec9388b3df0919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
randint()'s upper bound is exclusive, so we need to bump the 255 to 256 to ensure transformation methods behave correctly for all values.