Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vflip and Hflip In tensor format #1466

Merged
merged 7 commits into from
Oct 16, 2019
Merged

Conversation

surgan12
Copy link
Contributor

cc: @fmassa reopened.
ref: #1375

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #1466 into master will increase coverage by 0.12%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1466      +/-   ##
==========================================
+ Coverage   64.46%   64.58%   +0.12%     
==========================================
  Files          82       81       -1     
  Lines        6411     6399      -12     
  Branches      980     1000      +20     
==========================================
  Hits         4133     4133              
+ Misses       1990     1978      -12     
  Partials      288      288
Impacted Files Coverage Δ
torchvision/transforms/functional_tensor.py 60% <60%> (ø)
torchvision/ops/__init__.py 100% <0%> (ø) ⬆️
torchvision/ops/ps_roi_align.py
torchvision/ops/ps_roi_pool.py
torchvision/io/video.py 80.1% <0%> (+4.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896d7ec...4bb5bf7. Read the comment docs.

@fmassa
Copy link
Member

fmassa commented Oct 15, 2019

Didn't seem to work. I'll try contacting CircleCI to see what's going on

@fmassa
Copy link
Member

fmassa commented Oct 15, 2019

@surgan12 I found this on their support page https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization-

Can you follow what's listed there and let me know once you've done it?

@surgan12
Copy link
Contributor Author

Sure !!

@surgan12 surgan12 closed this Oct 15, 2019
@surgan12 surgan12 reopened this Oct 15, 2019
@fmassa fmassa closed this Oct 15, 2019
@fmassa fmassa reopened this Oct 15, 2019
@surgan12 surgan12 closed this Oct 15, 2019
@surgan12 surgan12 reopened this Oct 15, 2019
@surgan12 surgan12 closed this Oct 15, 2019
@surgan12 surgan12 reopened this Oct 15, 2019
@surgan12 surgan12 closed this Oct 15, 2019
@surgan12 surgan12 reopened this Oct 15, 2019
@fmassa
Copy link
Member

fmassa commented Oct 15, 2019

@surgan12 there is a problem with CI, I'm trying to fix it but I think there is no need to close-reopen the PR for now

@fmassa fmassa closed this Oct 16, 2019
@fmassa fmassa reopened this Oct 16, 2019
@fmassa
Copy link
Member

fmassa commented Oct 16, 2019

@surgan12 I've fixed CI in master, can you rebase your PR and do the change in CircleCI mentioned in https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization- so that we can run tests on your PR

@surgan12
Copy link
Contributor Author

@fmassa, the error has been resolved. Thanks !

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fmassa fmassa merged commit e279eba into pytorch:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants