Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Vflip and Hflip in Tensor format #1465

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions test/test_functional_tensor.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import torchvision.transforms.functional_tensor as F_t
import unittest
import torch


class Tester(unittest.TestCase):

def test_vflip(self):
img_tensor = torch.randn(3, 16, 16)
vflipped_img = F_t.vflip(img_tensor)
vflipped_img_again = F_t.vflip(vflipped_img)
self.assertEqual(vflipped_img.shape, img_tensor.shape)
self.assertTrue(torch.equal(img_tensor, vflipped_img_again))

def test_hflip(self):
img_tensor = torch.randn(3, 16, 16)
hflipped_img = F_t.hflip(img_tensor)
hflipped_img_again = F_t.hflip(hflipped_img)
self.assertEqual(hflipped_img.shape, img_tensor.shape)
self.assertTrue(torch.equal(img_tensor, hflipped_img_again))


if __name__ == '__main__':
unittest.main()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter is failing due to the missing newline here

33 changes: 33 additions & 0 deletions torchvision/transforms/functional_tensor.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import torch
import torchvision.transforms.functional as F


def vflip(img_tensor):
"""Vertically flip the given the Image Tensor.

Args:
img_tensor (Tensor): Image Tensor to be flipped in the form CXHXW.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you make it CxHxW or [C, H, W]? I think it's more readable.


Returns:
Tensor: Vertically flipped image Tensor.
"""
if not F._is_tensor_image(img_tensor):
raise TypeError('tensor is not a torch image.')

return img_tensor.flip(-2)


def hflip(img_tensor):
"""Horizontally flip the given the Image Tensor.

Args:
img_tensor (Tensor): Image Tensor to be flipped in the form CXHXW.

Returns:
Tensor: Horizontally flipped image Tensor.
"""

if not F._is_tensor_image(img_tensor):
raise TypeError('tensor is not a torch image.')

return img_tensor.flip(-1)