-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pillow 7.0.0 has removed PILLOW_VERSION
#1718
Comments
Thanks for opening the issue! This is a duplicate of #1712, and has been fixed in torchvision master already. We will be releasing a new version of torchvision early next week, which contains the fix. |
Summary: We are hitting an issue where torchvision current release is broken with the current version of PIL. So in OSS land, users with 0.4.2 who update their PIL version will have Classy Vision break if torchvision is included in a file. Torchvision will fix this next week, but then we will need our requirements to be updated. Should we use >= for our requirements rather than pinning to a specific torchvision version rather than updating with each torchvision release? RFC since the original diff (D18450381) undid the ">=" for pytorch and mentions pinning to 0.4.2, but the reasoning expressed in the diff seems to indicate that the goal was to get off torchvision nightly builds. For more details on PILLOW issue, see https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst#700-unreleased and pytorch/vision#1712 and pytorch/vision#1718 Reviewed By: vreis Differential Revision: D19279771 fbshipit-source-id: ff9c923e83da009fe4d9165cc2592177ae33405e
Summary: Pull Request resolved: fairinternal/ClassyVision#57 Pull Request resolved: #333 We are hitting an issue where torchvision current release is broken with the current version of PIL. So in OSS land, users with 0.4.2 who update their PIL version will have Classy Vision break if torchvision is included in a file. Torchvision will fix this next week, but then we will need our requirements to be updated. Should we use >= for our requirements rather than pinning to a specific torchvision version rather than updating with each torchvision release? RFC since the original diff (D18450381) undid the ">=" for pytorch and mentions pinning to 0.4.2, but the reasoning expressed in the diff seems to indicate that the goal was to get off torchvision nightly builds. For more details on PILLOW issue, see https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst#700-unreleased and pytorch/vision#1712 and pytorch/vision#1718 Reviewed By: vreis Differential Revision: D19279771 fbshipit-source-id: 880f81ca4b00dd7f541b7e2d60502b9839265422
what is the minimum version of pytorch and torchvision for this error to stop? |
What is the solution for this issue? I have pytorch 1.4.0 and it seems to still be a problem:
|
seems this temp soln works:
|
This issue is fixed with PyTorch and TorchVision nightlies. A new stable release of both libraries will be released next week. Note that the release 0.5.0 didn't contain the fix |
I am obtaining |
@free-soellingeraj I don't know. I don't think we provide docker images with our libraries. cc @seemethere |
In the newest version of
pillow
, the attributePILLOW_VERSION
is removed in favor ofPIL.__version__
.torchvision
relies on the old behaviour and breaks on import withSee for reference this issue in Pillow python-pillow/Pillow#4130.
I don't know if version 7 of Pillow breaks
torchvision
in other ways. Instead of resolving this directly, the<7.0
dependency rule could also be added to the requirements oftorchvision
.The text was updated successfully, but these errors were encountered: