[Multimodal model] Add the decoder of the multimodal model #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
awgu
reviewed
Oct 21, 2024
tianyu-l
reviewed
Oct 21, 2024
There was a problem hiding this comment.
As discussed offline, let's create separate files (in the folder) for encoder, decoder, and shared parts. This would make code more readable than a 1.5k LoC monolithic file.
I had a similar suggestion for ModelArgs, since it seems to be shared by encoder and decoder.
tianyu-l
approved these changes
Oct 23, 2024
mori360
pushed a commit
to mori360/torchtitan
that referenced
this pull request
Nov 26, 2024
After pytorch#589, we are adding decoder model to torchtitan with simple unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #589, we are adding decoder model to torchtitan with simple unit test.