remove PP tracer #555
Merged
remove PP tracer #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
Aug 22, 2024
ghstack-source-id: 6e56baaa8c48c451b6dac1945310e62d310b19f7 Pull Request resolved: #555
facebook-github-bot
added
the
CLA Signed
wconstab
approved these changes
Aug 22, 2024
Discussed with wconstab and kwen2501 , it seems PP tracer has two limitations right now: 1. It doesn't support `init_weights`, thus requiring a seed checkpoint to do init, which is something we probably will deprecate soon after we have the init support for manual splitting. 2. It doesn't support mixed precision training, as the tracer requires that the model being traced be consistent with the model during forward. We came to the conclusion to remove PP tracer for now, to have a clean version of torchtitan. [ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
Aug 22, 2024
ghstack-source-id: ab6a7cec6ba4f4690f5834d22bc16d8d9f2bdba8 Pull Request resolved: #555
tianyu-l
added a commit
that referenced
this pull request
Aug 22, 2024
ghstack-source-id: ab6a7cec6ba4f4690f5834d22bc16d8d9f2bdba8 Pull Request resolved: #555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Discussed with @wconstab and @kwen2501 , it seems PP tracer has two limitations right now:
init_weights, thus requiring a seed checkpoint to do init, which is something we probably will deprecate soon after we have the init support for manual splitting.We came to the conclusion to remove PP tracer for now, to have a clean version of torchtitan.