creates a sqs queue for retry failed scale-up requests #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
izaitsevfb
reviewed
Jan 30, 2023
terraform-aws-github-runner/modules/runners/lambdas/runners/src/lambda.ts
Show resolved
Hide resolved
izaitsevfb
reviewed
Jan 30, 2023
| for (const evt of evtFailed) { | ||
| const body: ActionRequestMessage = JSON.parse(evt.body); | ||
| const retryCount = body?.retryCount ?? 0; | ||
| const delaySeconds = Math.max(body?.delaySeconds ?? Config.Instance.retryScaleUpRecordDelayS / 2, 10); |
There was a problem hiding this comment.
Nit.
The delay calculation formula looks a bit confusing. I'd rewrite it in a more explicit manner, like:
if (body.delaySeconds === null) {
body.delaySeconds = Config.Instance.retryScaleUpRecordDelayS;
} else {
body.delaySeconds *= 2;
}
body.delaySeconds = Math.max(body.delaySeconds, 10);There was a problem hiding this comment.
I agree, much more readable this way
izaitsevfb
reviewed
Jan 30, 2023
terraform-aws-github-runner/modules/runners/lambdas/runners/src/lambda.test.ts
Show resolved
Hide resolved
izaitsevfb
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Overall, looks good. I'd appreciate the answer to this question, but, in any case, the change should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.