Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support group specification #616

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

lucifer1004
Copy link
Contributor

Description

I add an optional keyword argument group for all communication-related methods.

Motivation and Context

Close #615.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 11, 2024
@vmoens vmoens changed the title [feat] support group specification (fix #615) [Feature] Support group specification Jan 11, 2024
@vmoens vmoens added the enhancement New feature or request label Jan 11, 2024
@vmoens vmoens marked this pull request as ready for review January 11, 2024 08:55
@vmoens
Copy link
Contributor

vmoens commented Jan 11, 2024

@lucifer1004 I put the dist.smth type annotation in quotes because some pytorch installations don't have distributed package available (so loading tensordict will fail).
I also changed the signatures of the methods in a slightly bc-breaking way, in the sense that most args are now keyword args -- once we get many different args, we don't want to impose a clunky order, also because IMO group is more important than other args and should not be placed at the end. Happy to reconsider this!
LMK what you think of these changes!

@lucifer1004
Copy link
Contributor Author

@vmoens These changes look good to me.

@vmoens vmoens merged commit 5d45d83 into pytorch:main Jan 11, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support specifying group in isend and irecv
3 participants