Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Upload content of html directly #608

Merged
merged 3 commits into from
Jan 5, 2024
Merged

[BugFix] Upload content of html directly #608

merged 3 commits into from
Jan 5, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 5, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2024
@vmoens vmoens added the documentation Improvements or additions to documentation label Jan 5, 2024
@vmoens vmoens marked this pull request as ready for review January 5, 2024 08:26
@vmoens vmoens merged commit ada9e3c into main Jan 5, 2024
2 checks passed
@vmoens vmoens deleted the fix-upload2 branch January 5, 2024 08:26
Copy link

github-actions bot commented Jan 5, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 120. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 34.8150μs 16.3335μs 61.2238 KOps/s 61.6926 KOps/s $\color{#d91a1a}-0.76\%$
test_plain_set_stack_nested 0.2705ms 0.1450ms 6.8971 KOps/s 6.8773 KOps/s $\color{#35bf28}+0.29\%$
test_plain_set_nested_inplace 64.0400μs 18.5689μs 53.8534 KOps/s 53.7528 KOps/s $\color{#35bf28}+0.19\%$
test_plain_set_stack_nested_inplace 0.3221ms 0.1773ms 5.6387 KOps/s 5.6288 KOps/s $\color{#35bf28}+0.18\%$
test_items 20.9190μs 2.3471μs 426.0503 KOps/s 399.8466 KOps/s $\textbf{\color{#35bf28}+6.55\%}$
test_items_nested 0.8941ms 0.2730ms 3.6626 KOps/s 3.6032 KOps/s $\color{#35bf28}+1.65\%$
test_items_nested_locked 0.5441ms 0.2728ms 3.6661 KOps/s 3.6685 KOps/s $\color{#d91a1a}-0.07\%$
test_items_nested_leaf 0.5214ms 0.1693ms 5.9082 KOps/s 5.9188 KOps/s $\color{#d91a1a}-0.18\%$
test_items_stack_nested 1.4811ms 1.3208ms 757.1145 Ops/s 756.5023 Ops/s $\color{#35bf28}+0.08\%$
test_items_stack_nested_leaf 1.2827ms 1.1798ms 847.5945 Ops/s 842.7372 Ops/s $\color{#35bf28}+0.58\%$
test_items_stack_nested_locked 0.9090ms 0.7605ms 1.3150 KOps/s 1.2966 KOps/s $\color{#35bf28}+1.42\%$
test_keys 27.6320μs 3.8677μs 258.5487 KOps/s 263.2271 KOps/s $\color{#d91a1a}-1.78\%$
test_keys_nested 51.8766ms 0.1573ms 6.3557 KOps/s 6.7470 KOps/s $\textbf{\color{#d91a1a}-5.80\%}$
test_keys_nested_locked 0.3101ms 0.1464ms 6.8290 KOps/s 6.8200 KOps/s $\color{#35bf28}+0.13\%$
test_keys_nested_leaf 0.2419ms 0.1295ms 7.7243 KOps/s 7.7477 KOps/s $\color{#d91a1a}-0.30\%$
test_keys_stack_nested 1.5557ms 1.2715ms 786.4554 Ops/s 779.9260 Ops/s $\color{#35bf28}+0.84\%$
test_keys_stack_nested_leaf 1.9698ms 1.2688ms 788.1405 Ops/s 784.2438 Ops/s $\color{#35bf28}+0.50\%$
test_keys_stack_nested_locked 0.8575ms 0.6926ms 1.4438 KOps/s 1.4186 KOps/s $\color{#35bf28}+1.78\%$
test_values 9.4476μs 1.1525μs 867.6771 KOps/s 877.1540 KOps/s $\color{#d91a1a}-1.08\%$
test_values_nested 0.1025ms 51.7235μs 19.3336 KOps/s 19.4067 KOps/s $\color{#d91a1a}-0.38\%$
test_values_nested_locked 0.1344ms 51.7648μs 19.3182 KOps/s 19.4365 KOps/s $\color{#d91a1a}-0.61\%$
test_values_nested_leaf 0.1249ms 45.7352μs 21.8650 KOps/s 21.9829 KOps/s $\color{#d91a1a}-0.54\%$
test_values_stack_nested 1.1745ms 1.0452ms 956.7866 Ops/s 960.6741 Ops/s $\color{#d91a1a}-0.40\%$
test_values_stack_nested_leaf 1.5821ms 1.0292ms 971.6061 Ops/s 938.4909 Ops/s $\color{#35bf28}+3.53\%$
test_values_stack_nested_locked 0.8802ms 0.5064ms 1.9749 KOps/s 1.9244 KOps/s $\color{#35bf28}+2.62\%$
test_membership 22.6420μs 1.3302μs 751.7514 KOps/s 695.0546 KOps/s $\textbf{\color{#35bf28}+8.16\%}$
test_membership_nested 24.0550μs 2.8788μs 347.3644 KOps/s 341.7143 KOps/s $\color{#35bf28}+1.65\%$
test_membership_nested_leaf 27.5410μs 2.9691μs 336.7978 KOps/s 333.5829 KOps/s $\color{#35bf28}+0.96\%$
test_membership_stacked_nested 57.3660μs 11.8398μs 84.4607 KOps/s 87.2678 KOps/s $\color{#d91a1a}-3.22\%$
test_membership_stacked_nested_leaf 65.7580μs 11.7556μs 85.0656 KOps/s 86.3191 KOps/s $\color{#d91a1a}-1.45\%$
test_membership_nested_last 46.1390μs 6.0334μs 165.7453 KOps/s 165.4255 KOps/s $\color{#35bf28}+0.19\%$
test_membership_nested_leaf_last 40.7560μs 6.0650μs 164.8814 KOps/s 162.8869 KOps/s $\color{#35bf28}+1.22\%$
test_membership_stacked_nested_last 0.2293ms 0.1699ms 5.8852 KOps/s 5.9227 KOps/s $\color{#d91a1a}-0.63\%$
test_membership_stacked_nested_leaf_last 0.2524ms 14.6046μs 68.4715 KOps/s 73.1253 KOps/s $\textbf{\color{#d91a1a}-6.36\%}$
test_nested_getleaf 53.4390μs 10.9652μs 91.1973 KOps/s 93.0599 KOps/s $\color{#d91a1a}-2.00\%$
test_nested_get 57.4470μs 10.3778μs 96.3594 KOps/s 98.6194 KOps/s $\color{#d91a1a}-2.29\%$
test_stacked_getleaf 0.8734ms 0.4766ms 2.0984 KOps/s 2.1153 KOps/s $\color{#d91a1a}-0.80\%$
test_stacked_get 0.5228ms 0.4473ms 2.2357 KOps/s 2.2334 KOps/s $\color{#35bf28}+0.10\%$
test_nested_getitemleaf 48.5200μs 11.1207μs 89.9222 KOps/s 93.0983 KOps/s $\color{#d91a1a}-3.41\%$
test_nested_getitem 53.0980μs 10.4422μs 95.7653 KOps/s 98.3149 KOps/s $\color{#d91a1a}-2.59\%$
test_stacked_getitemleaf 0.8583ms 0.4773ms 2.0953 KOps/s 2.1101 KOps/s $\color{#d91a1a}-0.70\%$
test_stacked_getitem 0.5893ms 0.4429ms 2.2578 KOps/s 2.2460 KOps/s $\color{#35bf28}+0.52\%$
test_lock_nested 1.2448ms 0.4118ms 2.4285 KOps/s 2.3714 KOps/s $\color{#35bf28}+2.41\%$
test_lock_stack_nested 80.8269ms 6.6691ms 149.9442 Ops/s 149.4149 Ops/s $\color{#35bf28}+0.35\%$
test_unlock_nested 67.0590ms 0.4851ms 2.0612 KOps/s 2.3539 KOps/s $\textbf{\color{#d91a1a}-12.43\%}$
test_unlock_stack_nested 86.3785ms 6.2794ms 159.2519 Ops/s 158.3324 Ops/s $\color{#35bf28}+0.58\%$
test_flatten_speed 0.7257ms 0.3622ms 2.7609 KOps/s 2.7388 KOps/s $\color{#35bf28}+0.81\%$
test_unflatten_speed 0.9324ms 0.4612ms 2.1681 KOps/s 2.2010 KOps/s $\color{#d91a1a}-1.50\%$
test_common_ops 4.8172ms 0.6754ms 1.4805 KOps/s 1.5005 KOps/s $\color{#d91a1a}-1.33\%$
test_creation 39.6830μs 1.9750μs 506.3203 KOps/s 497.2773 KOps/s $\color{#35bf28}+1.82\%$
test_creation_empty 25.9780μs 9.1541μs 109.2410 KOps/s 120.2316 KOps/s $\textbf{\color{#d91a1a}-9.14\%}$
test_creation_nested_1 34.0330μs 11.9343μs 83.7919 KOps/s 89.1358 KOps/s $\textbf{\color{#d91a1a}-6.00\%}$
test_creation_nested_2 60.9930μs 17.0460μs 58.6649 KOps/s 60.2640 KOps/s $\color{#d91a1a}-2.65\%$
test_clone 0.2120ms 12.1038μs 82.6186 KOps/s 79.7157 KOps/s $\color{#35bf28}+3.64\%$
test_getitem[int] 91.7500μs 11.9025μs 84.0163 KOps/s 82.1303 KOps/s $\color{#35bf28}+2.30\%$
test_getitem[slice_int] 5.2156ms 25.8430μs 38.6951 KOps/s 40.6942 KOps/s $\color{#d91a1a}-4.91\%$
test_getitem[range] 0.1118ms 42.0201μs 23.7981 KOps/s 24.3736 KOps/s $\color{#d91a1a}-2.36\%$
test_getitem[tuple] 51.7870μs 19.2644μs 51.9093 KOps/s 51.4540 KOps/s $\color{#35bf28}+0.88\%$
test_getitem[list] 0.1228ms 37.9302μs 26.3642 KOps/s 27.4541 KOps/s $\color{#d91a1a}-3.97\%$
test_setitem_dim[int] 51.9270μs 30.2043μs 33.1079 KOps/s 33.6166 KOps/s $\color{#d91a1a}-1.51\%$
test_setitem_dim[slice_int] 87.8340μs 57.2327μs 17.4725 KOps/s 17.0100 KOps/s $\color{#35bf28}+2.72\%$
test_setitem_dim[range] 0.1584ms 77.2325μs 12.9479 KOps/s 13.9521 KOps/s $\textbf{\color{#d91a1a}-7.20\%}$
test_setitem_dim[tuple] 69.8700μs 44.9632μs 22.2404 KOps/s 22.9964 KOps/s $\color{#d91a1a}-3.29\%$
test_setitem 0.2316ms 17.7411μs 56.3662 KOps/s 56.5538 KOps/s $\color{#d91a1a}-0.33\%$
test_set 0.2827ms 17.3336μs 57.6914 KOps/s 58.3798 KOps/s $\color{#d91a1a}-1.18\%$
test_set_shared 4.3237ms 0.1371ms 7.2915 KOps/s 7.3181 KOps/s $\color{#d91a1a}-0.36\%$
test_update 0.2762ms 19.8861μs 50.2863 KOps/s 52.0775 KOps/s $\color{#d91a1a}-3.44\%$
test_update_nested 0.2502ms 26.6888μs 37.4689 KOps/s 37.9102 KOps/s $\color{#d91a1a}-1.16\%$
test_set_nested 0.2695ms 18.9528μs 52.7626 KOps/s 51.7043 KOps/s $\color{#35bf28}+2.05\%$
test_set_nested_new 0.2388ms 23.2161μs 43.0736 KOps/s 42.6198 KOps/s $\color{#35bf28}+1.06\%$
test_select 0.2374ms 47.4537μs 21.0732 KOps/s 20.7801 KOps/s $\color{#35bf28}+1.41\%$
test_unbind_speed 0.5027ms 0.3423ms 2.9214 KOps/s 2.8864 KOps/s $\color{#35bf28}+1.21\%$
test_unbind_speed_stack0 71.5059ms 4.1708ms 239.7629 Ops/s 248.5755 Ops/s $\color{#d91a1a}-3.55\%$
test_unbind_speed_stack1 6.4500μs 0.6378μs 1.5679 MOps/s 1.4431 MOps/s $\textbf{\color{#35bf28}+8.65\%}$
test_split 62.9922ms 1.6931ms 590.6478 Ops/s 580.5875 Ops/s $\color{#35bf28}+1.73\%$
test_chunk 66.5129ms 1.6723ms 597.9632 Ops/s 590.2960 Ops/s $\color{#35bf28}+1.30\%$
test_creation[device0] 0.4516ms 0.2947ms 3.3929 KOps/s 3.3981 KOps/s $\color{#d91a1a}-0.15\%$
test_creation_from_tensor 3.3659ms 0.3340ms 2.9944 KOps/s 3.0243 KOps/s $\color{#d91a1a}-0.99\%$
test_add_one[memmap_tensor0] 81.1710μs 25.9675μs 38.5096 KOps/s 38.9774 KOps/s $\color{#d91a1a}-1.20\%$
test_contiguous[memmap_tensor0] 26.1990μs 5.9844μs 167.1002 KOps/s 168.8585 KOps/s $\color{#d91a1a}-1.04\%$
test_stack[memmap_tensor0] 96.4590μs 19.8664μs 50.3362 KOps/s 49.7040 KOps/s $\color{#35bf28}+1.27\%$
test_memmaptd_index 0.2836ms 0.1998ms 5.0062 KOps/s 4.8291 KOps/s $\color{#35bf28}+3.67\%$
test_memmaptd_index_astensor 0.4125ms 0.2581ms 3.8751 KOps/s 3.7984 KOps/s $\color{#35bf28}+2.02\%$
test_memmaptd_index_op 0.6427ms 0.5227ms 1.9132 KOps/s 1.9620 KOps/s $\color{#d91a1a}-2.48\%$
test_serialize_model 0.1641s 0.1042s 9.5986 Ops/s 9.0886 Ops/s $\textbf{\color{#35bf28}+5.61\%}$
test_serialize_model_filesystem 0.1645s 96.4648ms 10.3665 Ops/s 9.8536 Ops/s $\textbf{\color{#35bf28}+5.21\%}$
test_serialize_model_pickle 0.4484s 0.3792s 2.6368 Ops/s 2.6301 Ops/s $\color{#35bf28}+0.25\%$
test_serialize_weights 0.1722s 0.1045s 9.5672 Ops/s 9.4381 Ops/s $\color{#35bf28}+1.37\%$
test_serialize_weights_filesystem 95.7052ms 90.3086ms 11.0731 Ops/s 10.8931 Ops/s $\color{#35bf28}+1.65\%$
test_serialize_weights_returnearly 0.1208s 0.1176s 8.5049 Ops/s 7.6203 Ops/s $\textbf{\color{#35bf28}+11.61\%}$
test_serialize_weights_pickle 0.9944s 0.7261s 1.3772 Ops/s 2.3355 Ops/s $\textbf{\color{#d91a1a}-41.03\%}$
test_reshape_pytree 48.8310μs 23.0760μs 43.3350 KOps/s 42.6182 KOps/s $\color{#35bf28}+1.68\%$
test_reshape_td 80.6200μs 30.0248μs 33.3058 KOps/s 32.5625 KOps/s $\color{#35bf28}+2.28\%$
test_view_pytree 78.5560μs 22.9552μs 43.5630 KOps/s 43.2904 KOps/s $\color{#35bf28}+0.63\%$
test_view_td 22.3420μs 4.9769μs 200.9269 KOps/s 201.8512 KOps/s $\color{#d91a1a}-0.46\%$
test_unbind_pytree 2.7009ms 26.5442μs 37.6730 KOps/s 37.1691 KOps/s $\color{#35bf28}+1.36\%$
test_unbind_td 0.1141ms 55.1741μs 18.1245 KOps/s 17.5694 KOps/s $\color{#35bf28}+3.16\%$
test_split_pytree 69.4400μs 26.4226μs 37.8464 KOps/s 36.6563 KOps/s $\color{#35bf28}+3.25\%$
test_split_td 0.5546ms 43.9579μs 22.7490 KOps/s 22.0639 KOps/s $\color{#35bf28}+3.11\%$
test_add_pytree 65.2610μs 32.2380μs 31.0193 KOps/s 30.4698 KOps/s $\color{#35bf28}+1.80\%$
test_add_td 0.1556ms 46.2322μs 21.6299 KOps/s 22.2478 KOps/s $\color{#d91a1a}-2.78\%$
test_distributed 32.5110μs 6.0833μs 164.3840 KOps/s 165.4393 KOps/s $\color{#d91a1a}-0.64\%$
test_tdmodule 0.7997ms 22.5492μs 44.3474 KOps/s 45.2341 KOps/s $\color{#d91a1a}-1.96\%$
test_tdmodule_dispatch 0.1940ms 39.9100μs 25.0564 KOps/s 24.9649 KOps/s $\color{#35bf28}+0.37\%$
test_tdseq 38.7630μs 25.0714μs 39.8861 KOps/s 40.6751 KOps/s $\color{#d91a1a}-1.94\%$
test_tdseq_dispatch 0.1397ms 45.1212μs 22.1625 KOps/s 22.6104 KOps/s $\color{#d91a1a}-1.98\%$
test_instantiation_functorch 1.6926ms 1.2946ms 772.4389 Ops/s 762.7699 Ops/s $\color{#35bf28}+1.27\%$
test_instantiation_td 2.0514ms 1.0094ms 990.6975 Ops/s 979.6717 Ops/s $\color{#35bf28}+1.13\%$
test_exec_functorch 0.3310ms 0.1579ms 6.3346 KOps/s 6.2954 KOps/s $\color{#35bf28}+0.62\%$
test_exec_functional_call 0.2437ms 0.1501ms 6.6636 KOps/s 6.7509 KOps/s $\color{#d91a1a}-1.29\%$
test_exec_td 0.2314ms 0.1434ms 6.9734 KOps/s 6.8248 KOps/s $\color{#35bf28}+2.18\%$
test_exec_td_decorator 0.6811ms 0.1733ms 5.7699 KOps/s 5.6336 KOps/s $\color{#35bf28}+2.42\%$
test_vmap_mlp_speed[True-True] 1.2398ms 0.8863ms 1.1283 KOps/s 1.0961 KOps/s $\color{#35bf28}+2.93\%$
test_vmap_mlp_speed[True-False] 0.9000ms 0.4723ms 2.1175 KOps/s 2.1084 KOps/s $\color{#35bf28}+0.43\%$
test_vmap_mlp_speed[False-True] 1.1143ms 0.7682ms 1.3017 KOps/s 1.2733 KOps/s $\color{#35bf28}+2.23\%$
test_vmap_mlp_speed[False-False] 0.6353ms 0.3856ms 2.5931 KOps/s 2.5621 KOps/s $\color{#35bf28}+1.21\%$
test_vmap_mlp_speed_decorator[True-True] 3.4961ms 1.7612ms 567.7805 Ops/s 566.0795 Ops/s $\color{#35bf28}+0.30\%$
test_vmap_mlp_speed_decorator[True-False] 0.9271ms 0.5174ms 1.9329 KOps/s 1.9280 KOps/s $\color{#35bf28}+0.25\%$
test_vmap_mlp_speed_decorator[False-True] 2.4570ms 1.4799ms 675.7356 Ops/s 678.8910 Ops/s $\color{#d91a1a}-0.46\%$
test_vmap_mlp_speed_decorator[False-False] 0.7130ms 0.3970ms 2.5192 KOps/s 2.5163 KOps/s $\color{#35bf28}+0.11\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants