Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix, Doc] Fix tutorial #606

Merged
merged 12 commits into from
Jan 4, 2024
Merged

[BugFix, Doc] Fix tutorial #606

merged 12 commits into from
Jan 4, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 4, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 120. Improved: $\large\color{#35bf28}16$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 43.0400μs 17.0627μs 58.6075 KOps/s 59.3187 KOps/s $\color{#d91a1a}-1.20\%$
test_plain_set_stack_nested 0.2615ms 0.1505ms 6.6438 KOps/s 7.0119 KOps/s $\textbf{\color{#d91a1a}-5.25\%}$
test_plain_set_nested_inplace 47.5190μs 18.7058μs 53.4594 KOps/s 52.6571 KOps/s $\color{#35bf28}+1.52\%$
test_plain_set_stack_nested_inplace 0.4023ms 0.1805ms 5.5399 KOps/s 5.6957 KOps/s $\color{#d91a1a}-2.74\%$
test_items 31.8200μs 2.3989μs 416.8542 KOps/s 402.7514 KOps/s $\color{#35bf28}+3.50\%$
test_items_nested 0.3617ms 0.2793ms 3.5801 KOps/s 3.6929 KOps/s $\color{#d91a1a}-3.06\%$
test_items_nested_locked 0.7264ms 0.2835ms 3.5279 KOps/s 3.6912 KOps/s $\color{#d91a1a}-4.42\%$
test_items_nested_leaf 0.5552ms 0.1721ms 5.8102 KOps/s 5.9734 KOps/s $\color{#d91a1a}-2.73\%$
test_items_stack_nested 1.5351ms 1.3212ms 756.8605 Ops/s 758.8523 Ops/s $\color{#d91a1a}-0.26\%$
test_items_stack_nested_leaf 1.7395ms 1.1885ms 841.4153 Ops/s 850.1758 Ops/s $\color{#d91a1a}-1.03\%$
test_items_stack_nested_locked 6.1112ms 0.8033ms 1.2448 KOps/s 1.3118 KOps/s $\textbf{\color{#d91a1a}-5.11\%}$
test_keys 59.2820μs 3.8339μs 260.8302 KOps/s 256.7364 KOps/s $\color{#35bf28}+1.59\%$
test_keys_nested 51.9950ms 0.1578ms 6.3379 KOps/s 6.7567 KOps/s $\textbf{\color{#d91a1a}-6.20\%}$
test_keys_nested_locked 0.2788ms 0.1447ms 6.9090 KOps/s 6.7644 KOps/s $\color{#35bf28}+2.14\%$
test_keys_nested_leaf 0.2436ms 0.1265ms 7.9023 KOps/s 7.6744 KOps/s $\color{#35bf28}+2.97\%$
test_keys_stack_nested 1.9543ms 1.2858ms 777.7164 Ops/s 776.1339 Ops/s $\color{#35bf28}+0.20\%$
test_keys_stack_nested_leaf 1.3839ms 1.2789ms 781.9075 Ops/s 783.4290 Ops/s $\color{#d91a1a}-0.19\%$
test_keys_stack_nested_locked 1.1217ms 0.6945ms 1.4399 KOps/s 1.4161 KOps/s $\color{#35bf28}+1.68\%$
test_values 10.5447μs 1.2226μs 817.9399 KOps/s 875.6343 KOps/s $\textbf{\color{#d91a1a}-6.59\%}$
test_values_nested 0.1191ms 53.8578μs 18.5674 KOps/s 19.0081 KOps/s $\color{#d91a1a}-2.32\%$
test_values_nested_locked 0.1120ms 54.0698μs 18.4946 KOps/s 19.0264 KOps/s $\color{#d91a1a}-2.79\%$
test_values_nested_leaf 92.2430μs 47.7649μs 20.9359 KOps/s 21.4470 KOps/s $\color{#d91a1a}-2.38\%$
test_values_stack_nested 1.6229ms 1.0397ms 961.8396 Ops/s 956.9326 Ops/s $\color{#35bf28}+0.51\%$
test_values_stack_nested_leaf 1.3314ms 1.0227ms 977.7809 Ops/s 947.1708 Ops/s $\color{#35bf28}+3.23\%$
test_values_stack_nested_locked 0.9179ms 0.5137ms 1.9467 KOps/s 1.9325 KOps/s $\color{#35bf28}+0.73\%$
test_membership 18.4640μs 1.3708μs 729.5161 KOps/s 727.2128 KOps/s $\color{#35bf28}+0.32\%$
test_membership_nested 41.3780μs 2.8771μs 347.5667 KOps/s 341.1137 KOps/s $\color{#35bf28}+1.89\%$
test_membership_nested_leaf 20.9490μs 2.8804μs 347.1792 KOps/s 328.2122 KOps/s $\textbf{\color{#35bf28}+5.78\%}$
test_membership_stacked_nested 24.5660μs 11.7266μs 85.2763 KOps/s 86.8138 KOps/s $\color{#d91a1a}-1.77\%$
test_membership_stacked_nested_leaf 39.0730μs 11.6944μs 85.5113 KOps/s 85.7622 KOps/s $\color{#d91a1a}-0.29\%$
test_membership_nested_last 47.0180μs 6.1444μs 162.7492 KOps/s 166.8099 KOps/s $\color{#d91a1a}-2.43\%$
test_membership_nested_leaf_last 46.4770μs 6.1599μs 162.3414 KOps/s 167.2332 KOps/s $\color{#d91a1a}-2.93\%$
test_membership_stacked_nested_last 0.2287ms 0.1692ms 5.9113 KOps/s 5.9215 KOps/s $\color{#d91a1a}-0.17\%$
test_membership_stacked_nested_leaf_last 42.2790μs 13.9076μs 71.9029 KOps/s 72.3277 KOps/s $\color{#d91a1a}-0.59\%$
test_nested_getleaf 50.1040μs 10.6006μs 94.3341 KOps/s 92.7718 KOps/s $\color{#35bf28}+1.68\%$
test_nested_get 51.4570μs 9.9587μs 100.4142 KOps/s 97.5984 KOps/s $\color{#35bf28}+2.89\%$
test_stacked_getleaf 0.5767ms 0.4647ms 2.1519 KOps/s 2.1426 KOps/s $\color{#35bf28}+0.43\%$
test_stacked_get 0.5208ms 0.4307ms 2.3218 KOps/s 2.3130 KOps/s $\color{#35bf28}+0.38\%$
test_nested_getitemleaf 36.1170μs 10.7662μs 92.8834 KOps/s 92.9076 KOps/s $\color{#d91a1a}-0.03\%$
test_nested_getitem 51.5860μs 10.2608μs 97.4584 KOps/s 99.0180 KOps/s $\color{#d91a1a}-1.58\%$
test_stacked_getitemleaf 0.6550ms 0.4667ms 2.1426 KOps/s 2.1362 KOps/s $\color{#35bf28}+0.30\%$
test_stacked_getitem 0.5690ms 0.4330ms 2.3097 KOps/s 2.3230 KOps/s $\color{#d91a1a}-0.57\%$
test_lock_nested 1.2781ms 0.4147ms 2.4114 KOps/s 2.3894 KOps/s $\color{#35bf28}+0.92\%$
test_lock_stack_nested 80.1760ms 6.7072ms 149.0930 Ops/s 145.1000 Ops/s $\color{#35bf28}+2.75\%$
test_unlock_nested 67.6120ms 0.4907ms 2.0380 KOps/s 2.3331 KOps/s $\textbf{\color{#d91a1a}-12.65\%}$
test_unlock_stack_nested 78.1478ms 6.2903ms 158.9744 Ops/s 157.9850 Ops/s $\color{#35bf28}+0.63\%$
test_flatten_speed 0.6154ms 0.3654ms 2.7370 KOps/s 2.7360 KOps/s $\color{#35bf28}+0.04\%$
test_unflatten_speed 0.5208ms 0.4576ms 2.1854 KOps/s 2.2274 KOps/s $\color{#d91a1a}-1.88\%$
test_common_ops 1.3524ms 0.6713ms 1.4897 KOps/s 1.4051 KOps/s $\textbf{\color{#35bf28}+6.02\%}$
test_creation 19.2360μs 1.9693μs 507.7927 KOps/s 503.1342 KOps/s $\color{#35bf28}+0.93\%$
test_creation_empty 30.9990μs 8.2530μs 121.1679 KOps/s 96.8288 KOps/s $\textbf{\color{#35bf28}+25.14\%}$
test_creation_nested_1 30.9580μs 11.1892μs 89.3718 KOps/s 75.5087 KOps/s $\textbf{\color{#35bf28}+18.36\%}$
test_creation_nested_2 50.2340μs 16.4322μs 60.8560 KOps/s 54.5541 KOps/s $\textbf{\color{#35bf28}+11.55\%}$
test_clone 0.1055ms 12.5372μs 79.7629 KOps/s 82.4751 KOps/s $\color{#d91a1a}-3.29\%$
test_getitem[int] 68.2790μs 12.4123μs 80.5650 KOps/s 84.1240 KOps/s $\color{#d91a1a}-4.23\%$
test_getitem[slice_int] 93.9460μs 23.5477μs 42.4670 KOps/s 41.9677 KOps/s $\color{#35bf28}+1.19\%$
test_getitem[range] 0.1122ms 41.4158μs 24.1454 KOps/s 23.6329 KOps/s $\color{#35bf28}+2.17\%$
test_getitem[tuple] 55.1540μs 19.6145μs 50.9826 KOps/s 51.6305 KOps/s $\color{#d91a1a}-1.25\%$
test_getitem[list] 0.2752ms 37.0126μs 27.0178 KOps/s 26.8167 KOps/s $\color{#35bf28}+0.75\%$
test_setitem_dim[int] 90.3990μs 29.0547μs 34.4178 KOps/s 31.6974 KOps/s $\textbf{\color{#35bf28}+8.58\%}$
test_setitem_dim[slice_int] 84.2580μs 55.8132μs 17.9169 KOps/s 17.1394 KOps/s $\color{#35bf28}+4.54\%$
test_setitem_dim[range] 0.1141ms 72.3331μs 13.8249 KOps/s 13.2855 KOps/s $\color{#35bf28}+4.06\%$
test_setitem_dim[tuple] 66.7450μs 43.3826μs 23.0507 KOps/s 21.4966 KOps/s $\textbf{\color{#35bf28}+7.23\%}$
test_setitem 0.2102ms 17.4839μs 57.1954 KOps/s 53.2375 KOps/s $\textbf{\color{#35bf28}+7.43\%}$
test_set 67.1460μs 17.1858μs 58.1876 KOps/s 55.8240 KOps/s $\color{#35bf28}+4.23\%$
test_set_shared 2.4452ms 0.1434ms 6.9756 KOps/s 7.1834 KOps/s $\color{#d91a1a}-2.89\%$
test_update 0.1791ms 19.3867μs 51.5818 KOps/s 47.1643 KOps/s $\textbf{\color{#35bf28}+9.37\%}$
test_update_nested 0.2180ms 26.6140μs 37.5742 KOps/s 35.3007 KOps/s $\textbf{\color{#35bf28}+6.44\%}$
test_set_nested 0.1951ms 18.9942μs 52.6477 KOps/s 49.2480 KOps/s $\textbf{\color{#35bf28}+6.90\%}$
test_set_nested_new 0.1403ms 23.7119μs 42.1729 KOps/s 41.2489 KOps/s $\color{#35bf28}+2.24\%$
test_select 94.5770μs 47.6879μs 20.9697 KOps/s 20.6911 KOps/s $\color{#35bf28}+1.35\%$
test_unbind_speed 0.4212ms 0.3402ms 2.9394 KOps/s 2.9265 KOps/s $\color{#35bf28}+0.44\%$
test_unbind_speed_stack0 73.7766ms 4.4261ms 225.9334 Ops/s 236.9945 Ops/s $\color{#d91a1a}-4.67\%$
test_unbind_speed_stack1 2.6520μs 0.6307μs 1.5855 MOps/s 1.6146 MOps/s $\color{#d91a1a}-1.80\%$
test_split 64.0852ms 1.6781ms 595.8951 Ops/s 594.2416 Ops/s $\color{#35bf28}+0.28\%$
test_chunk 1.6786ms 1.5455ms 647.0239 Ops/s 598.4736 Ops/s $\textbf{\color{#35bf28}+8.11\%}$
test_creation[device0] 0.4617ms 0.3030ms 3.3008 KOps/s 3.2949 KOps/s $\color{#35bf28}+0.18\%$
test_creation_from_tensor 2.7736ms 0.3407ms 2.9350 KOps/s 3.0009 KOps/s $\color{#d91a1a}-2.20\%$
test_add_one[memmap_tensor0] 0.3428ms 25.7438μs 38.8443 KOps/s 40.3616 KOps/s $\color{#d91a1a}-3.76\%$
test_contiguous[memmap_tensor0] 50.8860μs 5.9222μs 168.8565 KOps/s 172.2398 KOps/s $\color{#d91a1a}-1.96\%$
test_stack[memmap_tensor0] 54.3520μs 19.4039μs 51.5361 KOps/s 50.9226 KOps/s $\color{#35bf28}+1.20\%$
test_memmaptd_index 0.2882ms 0.2035ms 4.9128 KOps/s 4.9779 KOps/s $\color{#d91a1a}-1.31\%$
test_memmaptd_index_astensor 0.4233ms 0.2624ms 3.8109 KOps/s 3.8795 KOps/s $\color{#d91a1a}-1.77\%$
test_memmaptd_index_op 0.9187ms 0.5272ms 1.8970 KOps/s 1.8329 KOps/s $\color{#35bf28}+3.50\%$
test_serialize_model 0.1698s 0.1066s 9.3771 Ops/s 9.9568 Ops/s $\textbf{\color{#d91a1a}-5.82\%}$
test_serialize_model_filesystem 94.7353ms 91.7411ms 10.9002 Ops/s 9.7640 Ops/s $\textbf{\color{#35bf28}+11.64\%}$
test_serialize_model_pickle 0.4494s 0.3759s 2.6605 Ops/s 2.5948 Ops/s $\color{#35bf28}+2.53\%$
test_serialize_weights 0.1654s 0.1053s 9.4967 Ops/s 9.6229 Ops/s $\color{#d91a1a}-1.31\%$
test_serialize_weights_filesystem 0.1591s 96.4048ms 10.3729 Ops/s 10.8338 Ops/s $\color{#d91a1a}-4.25\%$
test_serialize_weights_returnearly 0.1957s 0.1288s 7.7648 Ops/s 7.7272 Ops/s $\color{#35bf28}+0.49\%$
test_serialize_weights_pickle 1.1458s 0.6490s 1.5408 Ops/s 2.0422 Ops/s $\textbf{\color{#d91a1a}-24.55\%}$
test_reshape_pytree 54.0110μs 23.1813μs 43.1382 KOps/s 43.0928 KOps/s $\color{#35bf28}+0.11\%$
test_reshape_td 65.5630μs 30.7086μs 32.5641 KOps/s 33.3108 KOps/s $\color{#d91a1a}-2.24\%$
test_view_pytree 59.7720μs 22.8482μs 43.7672 KOps/s 43.3098 KOps/s $\color{#35bf28}+1.06\%$
test_view_td 21.5000μs 4.7581μs 210.1667 KOps/s 207.5731 KOps/s $\color{#35bf28}+1.25\%$
test_unbind_pytree 60.8840μs 26.1876μs 38.1860 KOps/s 37.7214 KOps/s $\color{#35bf28}+1.23\%$
test_unbind_td 0.1061ms 55.1762μs 18.1238 KOps/s 18.4703 KOps/s $\color{#d91a1a}-1.88\%$
test_split_pytree 56.8560μs 26.3118μs 38.0058 KOps/s 38.6814 KOps/s $\color{#d91a1a}-1.75\%$
test_split_td 0.5252ms 43.2773μs 23.1068 KOps/s 22.4706 KOps/s $\color{#35bf28}+2.83\%$
test_add_pytree 93.2450μs 32.4336μs 30.8323 KOps/s 31.5056 KOps/s $\color{#d91a1a}-2.14\%$
test_add_td 0.1258ms 44.6732μs 22.3848 KOps/s 21.0399 KOps/s $\textbf{\color{#35bf28}+6.39\%}$
test_distributed 24.2350μs 5.9815μs 167.1815 KOps/s 159.6915 KOps/s $\color{#35bf28}+4.69\%$
test_tdmodule 0.7670ms 22.6302μs 44.1887 KOps/s 43.0384 KOps/s $\color{#35bf28}+2.67\%$
test_tdmodule_dispatch 0.2020ms 40.0170μs 24.9894 KOps/s 23.2012 KOps/s $\textbf{\color{#35bf28}+7.71\%}$
test_tdseq 0.1188ms 25.1341μs 39.7865 KOps/s 38.9855 KOps/s $\color{#35bf28}+2.05\%$
test_tdseq_dispatch 0.1364ms 44.2669μs 22.5903 KOps/s 21.8041 KOps/s $\color{#35bf28}+3.61\%$
test_instantiation_functorch 1.4973ms 1.2885ms 776.1247 Ops/s 776.7345 Ops/s $\color{#d91a1a}-0.08\%$
test_instantiation_td 1.4781ms 0.9984ms 1.0016 KOps/s 1.0025 KOps/s $\color{#d91a1a}-0.08\%$
test_exec_functorch 0.2391ms 0.1620ms 6.1713 KOps/s 6.3427 KOps/s $\color{#d91a1a}-2.70\%$
test_exec_functional_call 0.2357ms 0.1486ms 6.7294 KOps/s 6.7829 KOps/s $\color{#d91a1a}-0.79\%$
test_exec_td 0.2196ms 0.1430ms 6.9950 KOps/s 6.7688 KOps/s $\color{#35bf28}+3.34\%$
test_exec_td_decorator 0.6173ms 0.1743ms 5.7357 KOps/s 5.6682 KOps/s $\color{#35bf28}+1.19\%$
test_vmap_mlp_speed[True-True] 2.0149ms 0.9232ms 1.0832 KOps/s 1.1220 KOps/s $\color{#d91a1a}-3.46\%$
test_vmap_mlp_speed[True-False] 0.8770ms 0.4826ms 2.0720 KOps/s 2.1092 KOps/s $\color{#d91a1a}-1.76\%$
test_vmap_mlp_speed[False-True] 1.1173ms 0.7823ms 1.2782 KOps/s 1.2882 KOps/s $\color{#d91a1a}-0.77\%$
test_vmap_mlp_speed[False-False] 0.6214ms 0.3907ms 2.5595 KOps/s 2.6000 KOps/s $\color{#d91a1a}-1.56\%$
test_vmap_mlp_speed_decorator[True-True] 2.4033ms 1.7799ms 561.8243 Ops/s 520.1673 Ops/s $\textbf{\color{#35bf28}+8.01\%}$
test_vmap_mlp_speed_decorator[True-False] 0.9434ms 0.5213ms 1.9183 KOps/s 1.9232 KOps/s $\color{#d91a1a}-0.26\%$
test_vmap_mlp_speed_decorator[False-True] 2.3576ms 1.4943ms 669.1884 Ops/s 674.0631 Ops/s $\color{#d91a1a}-0.72\%$
test_vmap_mlp_speed_decorator[False-False] 0.8095ms 0.4034ms 2.4788 KOps/s 2.5257 KOps/s $\color{#d91a1a}-1.86\%$

@vmoens vmoens added the documentation Improvements or additions to documentation label Jan 4, 2024
@vmoens vmoens mentioned this pull request Jan 4, 2024
@vmoens vmoens merged commit 92f7f6f into main Jan 4, 2024
20 of 33 checks passed
@vmoens vmoens deleted the fix-tutorial branch January 4, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants