Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix osx tests #591

Merged
merged 1 commit into from
Dec 5, 2023
Merged

[BugFix] Fix osx tests #591

merged 1 commit into from
Dec 5, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Dec 5, 2023

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 113. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}21$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 34.6340μs 16.2313μs 61.6093 KOps/s 62.8207 KOps/s $\color{#d91a1a}-1.93\%$
test_plain_set_stack_nested 0.1980ms 0.1430ms 6.9949 KOps/s 6.9564 KOps/s $\color{#35bf28}+0.55\%$
test_plain_set_nested_inplace 51.5060μs 18.6024μs 53.7564 KOps/s 55.1369 KOps/s $\color{#d91a1a}-2.50\%$
test_plain_set_stack_nested_inplace 0.2467ms 0.1764ms 5.6677 KOps/s 5.6499 KOps/s $\color{#35bf28}+0.32\%$
test_items 18.9050μs 2.5770μs 388.0524 KOps/s 380.2759 KOps/s $\color{#35bf28}+2.04\%$
test_items_nested 0.5589ms 0.2658ms 3.7618 KOps/s 3.6952 KOps/s $\color{#35bf28}+1.80\%$
test_items_nested_locked 0.3172ms 0.2650ms 3.7743 KOps/s 3.7358 KOps/s $\color{#35bf28}+1.03\%$
test_items_nested_leaf 0.5761ms 0.1638ms 6.1060 KOps/s 6.0723 KOps/s $\color{#35bf28}+0.56\%$
test_items_stack_nested 2.2589ms 1.5115ms 661.5858 Ops/s 679.1683 Ops/s $\color{#d91a1a}-2.59\%$
test_items_stack_nested_leaf 1.5078ms 1.3551ms 737.9759 Ops/s 743.0623 Ops/s $\color{#d91a1a}-0.68\%$
test_items_stack_nested_locked 3.5946ms 0.8257ms 1.2111 KOps/s 1.2934 KOps/s $\textbf{\color{#d91a1a}-6.36\%}$
test_keys 18.7440μs 3.9215μs 255.0058 KOps/s 262.3706 KOps/s $\color{#d91a1a}-2.81\%$
test_keys_nested 3.3590ms 0.1435ms 6.9702 KOps/s 6.5985 KOps/s $\textbf{\color{#35bf28}+5.63\%}$
test_keys_nested_locked 0.1936ms 0.1431ms 6.9902 KOps/s 7.0826 KOps/s $\color{#d91a1a}-1.30\%$
test_keys_nested_leaf 0.4021ms 0.1425ms 7.0198 KOps/s 7.0843 KOps/s $\color{#d91a1a}-0.91\%$
test_keys_stack_nested 2.1964ms 1.4302ms 699.2163 Ops/s 709.2630 Ops/s $\color{#d91a1a}-1.42\%$
test_keys_stack_nested_leaf 2.1228ms 1.4269ms 700.8111 Ops/s 714.6302 Ops/s $\color{#d91a1a}-1.93\%$
test_keys_stack_nested_locked 1.2221ms 0.7013ms 1.4260 KOps/s 1.4370 KOps/s $\color{#d91a1a}-0.77\%$
test_values 42.2912μs 1.1725μs 852.8508 KOps/s 863.0592 KOps/s $\color{#d91a1a}-1.18\%$
test_values_nested 98.9340μs 48.7820μs 20.4994 KOps/s 20.2443 KOps/s $\color{#35bf28}+1.26\%$
test_values_nested_locked 98.7640μs 49.4711μs 20.2138 KOps/s 20.3361 KOps/s $\color{#d91a1a}-0.60\%$
test_values_nested_leaf 63.9400μs 44.7808μs 22.3310 KOps/s 22.5640 KOps/s $\color{#d91a1a}-1.03\%$
test_values_stack_nested 1.3529ms 1.1997ms 833.5133 Ops/s 835.1345 Ops/s $\color{#d91a1a}-0.19\%$
test_values_stack_nested_leaf 1.8657ms 1.1961ms 836.0296 Ops/s 835.9864 Ops/s $+0.01\%$
test_values_stack_nested_locked 0.7139ms 0.5245ms 1.9066 KOps/s 1.9172 KOps/s $\color{#d91a1a}-0.55\%$
test_membership 32.2200μs 1.3381μs 747.3297 KOps/s 727.9901 KOps/s $\color{#35bf28}+2.66\%$
test_membership_nested 26.7100μs 2.8007μs 357.0545 KOps/s 357.1680 KOps/s $\color{#d91a1a}-0.03\%$
test_membership_nested_leaf 40.7870μs 2.8315μs 353.1686 KOps/s 354.0139 KOps/s $\color{#d91a1a}-0.24\%$
test_membership_stacked_nested 38.4820μs 11.6622μs 85.7470 KOps/s 82.5173 KOps/s $\color{#35bf28}+3.91\%$
test_membership_stacked_nested_leaf 44.8230μs 11.7066μs 85.4220 KOps/s 85.8789 KOps/s $\color{#d91a1a}-0.53\%$
test_membership_nested_last 36.3880μs 5.9348μs 168.4986 KOps/s 171.1685 KOps/s $\color{#d91a1a}-1.56\%$
test_membership_nested_leaf_last 24.5360μs 5.8975μs 169.5628 KOps/s 170.1178 KOps/s $\color{#d91a1a}-0.33\%$
test_membership_stacked_nested_last 0.2287ms 0.1677ms 5.9635 KOps/s 5.9384 KOps/s $\color{#35bf28}+0.42\%$
test_membership_stacked_nested_leaf_last 49.4530μs 13.7286μs 72.8407 KOps/s 73.3742 KOps/s $\color{#d91a1a}-0.73\%$
test_nested_getleaf 57.3890μs 10.5542μs 94.7489 KOps/s 92.7326 KOps/s $\color{#35bf28}+2.17\%$
test_nested_get 40.6960μs 10.1387μs 98.6316 KOps/s 97.7644 KOps/s $\color{#35bf28}+0.89\%$
test_stacked_getleaf 1.1392ms 0.6383ms 1.5667 KOps/s 1.5353 KOps/s $\color{#35bf28}+2.05\%$
test_stacked_get 1.4791ms 0.6199ms 1.6131 KOps/s 1.5855 KOps/s $\color{#35bf28}+1.74\%$
test_nested_getitemleaf 41.7880μs 10.5698μs 94.6093 KOps/s 94.0196 KOps/s $\color{#35bf28}+0.63\%$
test_nested_getitem 28.2820μs 10.0867μs 99.1400 KOps/s 99.0174 KOps/s $\color{#35bf28}+0.12\%$
test_stacked_getitemleaf 1.0824ms 0.6387ms 1.5656 KOps/s 1.5852 KOps/s $\color{#d91a1a}-1.24\%$
test_stacked_getitem 0.7072ms 0.6076ms 1.6459 KOps/s 1.6375 KOps/s $\color{#35bf28}+0.51\%$
test_lock_nested 7.3105ms 0.5744ms 1.7408 KOps/s 1.7576 KOps/s $\color{#d91a1a}-0.96\%$
test_lock_stack_nested 7.8447ms 5.1267ms 195.0581 Ops/s 195.9272 Ops/s $\color{#d91a1a}-0.44\%$
test_unlock_nested 75.4495ms 0.5256ms 1.9025 KOps/s 2.2579 KOps/s $\textbf{\color{#d91a1a}-15.74\%}$
test_unlock_stack_nested 80.6075ms 7.1534ms 139.7938 Ops/s 143.5879 Ops/s $\color{#d91a1a}-2.64\%$
test_flatten_speed 0.6412ms 0.2685ms 3.7250 KOps/s 3.7497 KOps/s $\color{#d91a1a}-0.66\%$
test_unflatten_speed 0.7313ms 0.4643ms 2.1540 KOps/s 2.1031 KOps/s $\color{#35bf28}+2.42\%$
test_common_ops 3.4798ms 0.6966ms 1.4356 KOps/s 1.4991 KOps/s $\color{#d91a1a}-4.23\%$
test_creation 19.3770μs 2.5263μs 395.8312 KOps/s 403.8138 KOps/s $\color{#d91a1a}-1.98\%$
test_creation_empty 26.9000μs 9.2183μs 108.4794 KOps/s 116.7412 KOps/s $\textbf{\color{#d91a1a}-7.08\%}$
test_creation_nested_1 35.6760μs 12.6275μs 79.1924 KOps/s 84.8422 KOps/s $\textbf{\color{#d91a1a}-6.66\%}$
test_creation_nested_2 38.5320μs 16.4440μs 60.8123 KOps/s 65.5515 KOps/s $\textbf{\color{#d91a1a}-7.23\%}$
test_clone 0.1341ms 14.0736μs 71.0549 KOps/s 73.3926 KOps/s $\color{#d91a1a}-3.19\%$
test_getitem[int] 41.3970μs 13.8125μs 72.3984 KOps/s 77.7713 KOps/s $\textbf{\color{#d91a1a}-6.91\%}$
test_getitem[slice_int] 77.5040μs 26.4408μs 37.8204 KOps/s 40.4762 KOps/s $\textbf{\color{#d91a1a}-6.56\%}$
test_getitem[range] 93.7040μs 46.3303μs 21.5841 KOps/s 22.6128 KOps/s $\color{#d91a1a}-4.55\%$
test_getitem[tuple] 67.4650μs 21.6931μs 46.0976 KOps/s 48.9230 KOps/s $\textbf{\color{#d91a1a}-5.78\%}$
test_getitem[list] 0.4166ms 41.2589μs 24.2372 KOps/s 24.3674 KOps/s $\color{#d91a1a}-0.53\%$
test_setitem_dim[int] 60.8740μs 29.6169μs 33.7645 KOps/s 35.7489 KOps/s $\textbf{\color{#d91a1a}-5.55\%}$
test_setitem_dim[slice_int] 99.5050μs 55.5543μs 18.0004 KOps/s 19.4869 KOps/s $\textbf{\color{#d91a1a}-7.63\%}$
test_setitem_dim[range] 0.1317ms 73.7101μs 13.5667 KOps/s 13.9070 KOps/s $\color{#d91a1a}-2.45\%$
test_setitem_dim[tuple] 78.3360μs 43.1924μs 23.1522 KOps/s 24.9161 KOps/s $\textbf{\color{#d91a1a}-7.08\%}$
test_setitem 0.1892ms 19.9093μs 50.2277 KOps/s 54.1219 KOps/s $\textbf{\color{#d91a1a}-7.20\%}$
test_set 0.1803ms 19.3851μs 51.5860 KOps/s 55.7824 KOps/s $\textbf{\color{#d91a1a}-7.52\%}$
test_set_shared 8.3932ms 0.1451ms 6.8910 KOps/s 7.0762 KOps/s $\color{#d91a1a}-2.62\%$
test_update 0.2163ms 20.9127μs 47.8177 KOps/s 52.1726 KOps/s $\textbf{\color{#d91a1a}-8.35\%}$
test_update_nested 0.1731ms 29.0341μs 34.4423 KOps/s 38.1020 KOps/s $\textbf{\color{#d91a1a}-9.61\%}$
test_set_nested 0.1527ms 21.5399μs 46.4255 KOps/s 50.5373 KOps/s $\textbf{\color{#d91a1a}-8.14\%}$
test_set_nested_new 0.2134ms 27.2306μs 36.7233 KOps/s 40.3893 KOps/s $\textbf{\color{#d91a1a}-9.08\%}$
test_select 0.2124ms 53.5063μs 18.6894 KOps/s 20.1779 KOps/s $\textbf{\color{#d91a1a}-7.38\%}$
test_unbind_speed 0.5152ms 0.3846ms 2.6003 KOps/s 2.6751 KOps/s $\color{#d91a1a}-2.79\%$
test_unbind_speed_stack0 72.8146ms 4.9292ms 202.8722 Ops/s 204.3809 Ops/s $\color{#d91a1a}-0.74\%$
test_unbind_speed_stack1 1.6626μs 0.6396μs 1.5635 MOps/s 1.5368 MOps/s $\color{#35bf28}+1.73\%$
test_split 56.1286ms 1.7883ms 559.1793 Ops/s 594.7866 Ops/s $\textbf{\color{#d91a1a}-5.99\%}$
test_chunk 1.7472ms 1.6657ms 600.3386 Ops/s 565.4847 Ops/s $\textbf{\color{#35bf28}+6.16\%}$
test_creation[device0] 0.5779ms 0.2978ms 3.3575 KOps/s 3.3784 KOps/s $\color{#d91a1a}-0.62\%$
test_creation_from_tensor 3.3830ms 0.3432ms 2.9135 KOps/s 3.0334 KOps/s $\color{#d91a1a}-3.95\%$
test_add_one[memmap_tensor0] 0.4433ms 26.8350μs 37.2648 KOps/s 39.1590 KOps/s $\color{#d91a1a}-4.84\%$
test_contiguous[memmap_tensor0] 41.0360μs 5.9232μs 168.8271 KOps/s 173.3751 KOps/s $\color{#d91a1a}-2.62\%$
test_stack[memmap_tensor0] 98.3930μs 19.5694μs 51.1001 KOps/s 50.4961 KOps/s $\color{#35bf28}+1.20\%$
test_memmaptd_index 0.4077ms 0.2072ms 4.8255 KOps/s 4.8868 KOps/s $\color{#d91a1a}-1.26\%$
test_memmaptd_index_astensor 0.3663ms 0.2649ms 3.7754 KOps/s 3.8108 KOps/s $\color{#d91a1a}-0.93\%$
test_memmaptd_index_op 0.9207ms 0.5217ms 1.9169 KOps/s 1.9269 KOps/s $\color{#d91a1a}-0.52\%$
test_reshape_pytree 54.6220μs 23.2258μs 43.0556 KOps/s 42.7410 KOps/s $\color{#35bf28}+0.74\%$
test_reshape_td 86.8620μs 32.3318μs 30.9293 KOps/s 32.0038 KOps/s $\color{#d91a1a}-3.36\%$
test_view_pytree 53.2390μs 22.9869μs 43.5030 KOps/s 42.6653 KOps/s $\color{#35bf28}+1.96\%$
test_view_td 24.6360μs 4.8590μs 205.8042 KOps/s 199.5341 KOps/s $\color{#35bf28}+3.14\%$
test_unbind_pytree 64.1290μs 26.4098μs 37.8648 KOps/s 37.7637 KOps/s $\color{#35bf28}+0.27\%$
test_unbind_td 0.1166ms 61.1128μs 16.3632 KOps/s 16.8428 KOps/s $\color{#d91a1a}-2.85\%$
test_split_pytree 92.5920μs 27.1300μs 36.8595 KOps/s 38.1108 KOps/s $\color{#d91a1a}-3.28\%$
test_split_td 0.1675ms 49.9047μs 20.0382 KOps/s 21.7134 KOps/s $\textbf{\color{#d91a1a}-7.72\%}$
test_add_pytree 72.5150μs 32.1710μs 31.0839 KOps/s 31.5171 KOps/s $\color{#d91a1a}-1.37\%$
test_add_td 0.1359ms 48.7495μs 20.5130 KOps/s 22.3429 KOps/s $\textbf{\color{#d91a1a}-8.19\%}$
test_distributed 30.1460μs 6.1654μs 162.1950 KOps/s 166.0894 KOps/s $\color{#d91a1a}-2.34\%$
test_tdmodule 1.5988ms 22.5667μs 44.3130 KOps/s 45.5893 KOps/s $\color{#d91a1a}-2.80\%$
test_tdmodule_dispatch 0.1888ms 40.0195μs 24.9878 KOps/s 24.9203 KOps/s $\color{#35bf28}+0.27\%$
test_tdseq 0.1398ms 25.1098μs 39.8251 KOps/s 40.9412 KOps/s $\color{#d91a1a}-2.73\%$
test_tdseq_dispatch 0.1393ms 44.7057μs 22.3685 KOps/s 22.8910 KOps/s $\color{#d91a1a}-2.28\%$
test_instantiation_functorch 2.1261ms 1.3277ms 753.1773 Ops/s 766.7847 Ops/s $\color{#d91a1a}-1.77\%$
test_instantiation_td 1.6638ms 1.0344ms 966.7437 Ops/s 966.4669 Ops/s $\color{#35bf28}+0.03\%$
test_exec_functorch 0.3021ms 0.1569ms 6.3716 KOps/s 6.2107 KOps/s $\color{#35bf28}+2.59\%$
test_exec_functional_call 0.2389ms 0.1456ms 6.8703 KOps/s 6.4541 KOps/s $\textbf{\color{#35bf28}+6.45\%}$
test_exec_td 0.3587ms 0.1433ms 6.9769 KOps/s 6.7086 KOps/s $\color{#35bf28}+4.00\%$
test_exec_td_decorator 0.9803ms 0.1784ms 5.6041 KOps/s 5.5675 KOps/s $\color{#35bf28}+0.66\%$
test_vmap_mlp_speed[True-True] 1.2993ms 0.9196ms 1.0874 KOps/s 1.0995 KOps/s $\color{#d91a1a}-1.10\%$
test_vmap_mlp_speed[True-False] 0.5979ms 0.4781ms 2.0915 KOps/s 2.0905 KOps/s $\color{#35bf28}+0.05\%$
test_vmap_mlp_speed[False-True] 1.2084ms 0.8003ms 1.2495 KOps/s 1.2720 KOps/s $\color{#d91a1a}-1.77\%$
test_vmap_mlp_speed[False-False] 0.8483ms 0.3944ms 2.5357 KOps/s 2.5007 KOps/s $\color{#35bf28}+1.40\%$
test_vmap_mlp_speed_decorator[True-True] 2.9588ms 1.8210ms 549.1619 Ops/s 571.6871 Ops/s $\color{#d91a1a}-3.94\%$
test_vmap_mlp_speed_decorator[True-False] 1.3175ms 0.5324ms 1.8784 KOps/s 1.8118 KOps/s $\color{#35bf28}+3.68\%$
test_vmap_mlp_speed_decorator[False-True] 2.3310ms 1.5407ms 649.0670 Ops/s 665.8716 Ops/s $\color{#d91a1a}-2.52\%$
test_vmap_mlp_speed_decorator[False-False] 0.9697ms 0.4065ms 2.4601 KOps/s 2.4228 KOps/s $\color{#35bf28}+1.54\%$

Copy link

github-actions bot commented Dec 5, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 127. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 0.4525ms 12.7875μs 78.2016 KOps/s 77.5941 KOps/s $\color{#35bf28}+0.78\%$
test_plain_set_stack_nested 0.1379ms 0.1165ms 8.5861 KOps/s 8.2453 KOps/s $\color{#35bf28}+4.13\%$
test_plain_set_nested_inplace 35.1710μs 14.0735μs 71.0558 KOps/s 70.3859 KOps/s $\color{#35bf28}+0.95\%$
test_plain_set_stack_nested_inplace 0.1876ms 0.1452ms 6.8875 KOps/s 6.8113 KOps/s $\color{#35bf28}+1.12\%$
test_items 24.0310μs 4.7365μs 211.1273 KOps/s 211.5495 KOps/s $\color{#d91a1a}-0.20\%$
test_items_nested 0.3891ms 0.3366ms 2.9710 KOps/s 2.9135 KOps/s $\color{#35bf28}+1.97\%$
test_items_nested_locked 0.3655ms 0.3394ms 2.9463 KOps/s 2.8636 KOps/s $\color{#35bf28}+2.89\%$
test_items_nested_leaf 0.2228ms 0.1991ms 5.0218 KOps/s 4.9599 KOps/s $\color{#35bf28}+1.25\%$
test_items_stack_nested 1.5660ms 1.5252ms 655.6421 Ops/s 658.3649 Ops/s $\color{#d91a1a}-0.41\%$
test_items_stack_nested_leaf 1.4327ms 1.3397ms 746.4266 Ops/s 740.1085 Ops/s $\color{#35bf28}+0.85\%$
test_items_stack_nested_locked 0.9119ms 0.8502ms 1.1761 KOps/s 1.1485 KOps/s $\color{#35bf28}+2.41\%$
test_keys 21.9900μs 4.6181μs 216.5387 KOps/s 217.8173 KOps/s $\color{#d91a1a}-0.59\%$
test_keys_nested 3.5250ms 90.6564μs 11.0307 KOps/s 10.9377 KOps/s $\color{#35bf28}+0.85\%$
test_keys_nested_locked 0.1108ms 90.0993μs 11.0989 KOps/s 11.0430 KOps/s $\color{#35bf28}+0.51\%$
test_keys_nested_leaf 42.1407ms 87.1639μs 11.4726 KOps/s 12.0046 KOps/s $\color{#d91a1a}-4.43\%$
test_keys_stack_nested 1.4480ms 1.3356ms 748.7201 Ops/s 746.0575 Ops/s $\color{#35bf28}+0.36\%$
test_keys_stack_nested_leaf 1.3740ms 1.3239ms 755.3478 Ops/s 751.8583 Ops/s $\color{#35bf28}+0.46\%$
test_keys_stack_nested_locked 0.6864ms 0.6510ms 1.5361 KOps/s 1.5096 KOps/s $\color{#35bf28}+1.75\%$
test_values 9.1303μs 1.8933μs 528.1727 KOps/s 524.2113 KOps/s $\color{#35bf28}+0.76\%$
test_values_nested 58.5210μs 43.1281μs 23.1867 KOps/s 23.0343 KOps/s $\color{#35bf28}+0.66\%$
test_values_nested_locked 66.0920μs 45.6643μs 21.8990 KOps/s 21.8235 KOps/s $\color{#35bf28}+0.35\%$
test_values_nested_leaf 67.3510μs 37.7772μs 26.4710 KOps/s 26.3861 KOps/s $\color{#35bf28}+0.32\%$
test_values_stack_nested 1.2597ms 1.1894ms 840.7728 Ops/s 856.0990 Ops/s $\color{#d91a1a}-1.79\%$
test_values_stack_nested_leaf 1.3183ms 1.1718ms 853.4148 Ops/s 861.6516 Ops/s $\color{#d91a1a}-0.96\%$
test_values_stack_nested_locked 0.5716ms 0.5313ms 1.8823 KOps/s 1.9040 KOps/s $\color{#d91a1a}-1.14\%$
test_membership 5.1740μs 0.9345μs 1.0701 MOps/s 1.0544 MOps/s $\color{#35bf28}+1.49\%$
test_membership_nested 18.1000μs 2.2284μs 448.7450 KOps/s 443.7922 KOps/s $\color{#35bf28}+1.12\%$
test_membership_nested_leaf 17.7550μs 2.1305μs 469.3808 KOps/s 462.5001 KOps/s $\color{#35bf28}+1.49\%$
test_membership_stacked_nested 47.0610μs 11.3110μs 88.4096 KOps/s 88.6966 KOps/s $\color{#d91a1a}-0.32\%$
test_membership_stacked_nested_leaf 29.6310μs 11.1928μs 89.3431 KOps/s 88.8259 KOps/s $\color{#35bf28}+0.58\%$
test_membership_nested_last 48.9910μs 4.6140μs 216.7316 KOps/s 214.1228 KOps/s $\color{#35bf28}+1.22\%$
test_membership_nested_leaf_last 31.2100μs 4.6161μs 216.6324 KOps/s 214.3094 KOps/s $\color{#35bf28}+1.08\%$
test_membership_stacked_nested_last 0.1625ms 0.1342ms 7.4530 KOps/s 7.4233 KOps/s $\color{#35bf28}+0.40\%$
test_membership_stacked_nested_leaf_last 44.6900μs 13.0570μs 76.5871 KOps/s 76.0403 KOps/s $\color{#35bf28}+0.72\%$
test_nested_getleaf 31.7800μs 8.4342μs 118.5653 KOps/s 118.3122 KOps/s $\color{#35bf28}+0.21\%$
test_nested_get 28.6810μs 7.9947μs 125.0827 KOps/s 125.0279 KOps/s $\color{#35bf28}+0.04\%$
test_stacked_getleaf 0.6285ms 0.5790ms 1.7270 KOps/s 1.7596 KOps/s $\color{#d91a1a}-1.85\%$
test_stacked_get 0.5875ms 0.5412ms 1.8479 KOps/s 1.8669 KOps/s $\color{#d91a1a}-1.02\%$
test_nested_getitemleaf 29.3500μs 8.4999μs 117.6483 KOps/s 117.9606 KOps/s $\color{#d91a1a}-0.26\%$
test_nested_getitem 31.5000μs 8.0422μs 124.3442 KOps/s 124.8130 KOps/s $\color{#d91a1a}-0.38\%$
test_stacked_getitemleaf 0.6538ms 0.5742ms 1.7415 KOps/s 1.7524 KOps/s $\color{#d91a1a}-0.62\%$
test_stacked_getitem 0.5833ms 0.5361ms 1.8653 KOps/s 1.8644 KOps/s $\color{#35bf28}+0.05\%$
test_lock_nested 3.3651ms 0.5749ms 1.7393 KOps/s 1.7794 KOps/s $\color{#d91a1a}-2.25\%$
test_lock_stack_nested 82.8602ms 7.4586ms 134.0735 Ops/s 135.4277 Ops/s $\color{#d91a1a}-1.00\%$
test_unlock_nested 2.4108ms 0.4454ms 2.2450 KOps/s 2.2679 KOps/s $\color{#d91a1a}-1.01\%$
test_unlock_stack_nested 67.9830ms 6.4651ms 154.6772 Ops/s 159.4078 Ops/s $\color{#d91a1a}-2.97\%$
test_flatten_speed 0.2258ms 0.1871ms 5.3437 KOps/s 5.3033 KOps/s $\color{#35bf28}+0.76\%$
test_unflatten_speed 0.3993ms 0.3667ms 2.7270 KOps/s 2.7182 KOps/s $\color{#35bf28}+0.33\%$
test_common_ops 1.1789ms 0.6322ms 1.5819 KOps/s 1.5585 KOps/s $\color{#35bf28}+1.50\%$
test_creation 31.7300μs 2.1327μs 468.8971 KOps/s 470.0273 KOps/s $\color{#d91a1a}-0.24\%$
test_creation_empty 35.2600μs 7.2876μs 137.2190 KOps/s 136.8274 KOps/s $\color{#35bf28}+0.29\%$
test_creation_nested_1 23.7310μs 9.5943μs 104.2286 KOps/s 103.9368 KOps/s $\color{#35bf28}+0.28\%$
test_creation_nested_2 40.5900μs 12.3617μs 80.8950 KOps/s 81.3475 KOps/s $\color{#d91a1a}-0.56\%$
test_clone 90.5320μs 15.3635μs 65.0892 KOps/s 64.7388 KOps/s $\color{#35bf28}+0.54\%$
test_getitem[int] 27.2400μs 12.7558μs 78.3959 KOps/s 77.4860 KOps/s $\color{#35bf28}+1.17\%$
test_getitem[slice_int] 56.0910μs 24.3491μs 41.0693 KOps/s 40.5923 KOps/s $\color{#35bf28}+1.18\%$
test_getitem[range] 78.0010μs 43.7287μs 22.8683 KOps/s 23.3476 KOps/s $\color{#d91a1a}-2.05\%$
test_getitem[tuple] 42.3210μs 21.2063μs 47.1559 KOps/s 47.6594 KOps/s $\color{#d91a1a}-1.06\%$
test_getitem[list] 0.2709ms 39.9145μs 25.0536 KOps/s 25.3733 KOps/s $\color{#d91a1a}-1.26\%$
test_setitem_dim[int] 43.9810μs 28.5055μs 35.0810 KOps/s 36.7547 KOps/s $\color{#d91a1a}-4.55\%$
test_setitem_dim[slice_int] 68.9010μs 49.1430μs 20.3488 KOps/s 20.7500 KOps/s $\color{#d91a1a}-1.93\%$
test_setitem_dim[range] 83.8910μs 66.6634μs 15.0007 KOps/s 15.1525 KOps/s $\color{#d91a1a}-1.00\%$
test_setitem_dim[tuple] 58.2700μs 42.4730μs 23.5444 KOps/s 24.1852 KOps/s $\color{#d91a1a}-2.65\%$
test_setitem 97.8120μs 19.3098μs 51.7872 KOps/s 51.4900 KOps/s $\color{#35bf28}+0.58\%$
test_set 82.9820μs 19.0438μs 52.5105 KOps/s 52.6182 KOps/s $\color{#d91a1a}-0.20\%$
test_set_shared 2.5353ms 0.1089ms 9.1833 KOps/s 8.4796 KOps/s $\textbf{\color{#35bf28}+8.30\%}$
test_update 0.1005ms 20.0898μs 49.7766 KOps/s 49.1771 KOps/s $\color{#35bf28}+1.22\%$
test_update_nested 0.1216ms 27.0638μs 36.9497 KOps/s 37.4318 KOps/s $\color{#d91a1a}-1.29\%$
test_set_nested 91.1610μs 20.5113μs 48.7537 KOps/s 48.8818 KOps/s $\color{#d91a1a}-0.26\%$
test_set_nested_new 0.1065ms 25.3853μs 39.3929 KOps/s 40.8323 KOps/s $\color{#d91a1a}-3.53\%$
test_select 89.5610μs 48.6075μs 20.5730 KOps/s 20.9569 KOps/s $\color{#d91a1a}-1.83\%$
test_to 75.8410μs 55.0959μs 18.1502 KOps/s 18.0604 KOps/s $\color{#35bf28}+0.50\%$
test_to_nonblocking 70.7110μs 36.8609μs 27.1290 KOps/s 27.2120 KOps/s $\color{#d91a1a}-0.30\%$
test_unbind_speed 0.4001ms 0.3737ms 2.6763 KOps/s 2.7275 KOps/s $\color{#d91a1a}-1.88\%$
test_unbind_speed_stack0 62.9095ms 4.5329ms 220.6117 Ops/s 242.5053 Ops/s $\textbf{\color{#d91a1a}-9.03\%}$
test_unbind_speed_stack1 1.6701μs 0.5328μs 1.8769 MOps/s 1.8355 MOps/s $\color{#35bf28}+2.26\%$
test_split 54.5456ms 1.8754ms 533.2111 Ops/s 547.9011 Ops/s $\color{#d91a1a}-2.68\%$
test_chunk 1.7937ms 1.7648ms 566.6495 Ops/s 557.7555 Ops/s $\color{#35bf28}+1.59\%$
test_creation[device0] 0.3827ms 0.3102ms 3.2234 KOps/s 3.2232 KOps/s $+0.01\%$
test_creation[device1] 0.6742ms 0.3146ms 3.1782 KOps/s 3.1884 KOps/s $\color{#d91a1a}-0.32\%$
test_creation_from_tensor 0.6328ms 0.3396ms 2.9445 KOps/s 2.9436 KOps/s $\color{#35bf28}+0.03\%$
test_add_one[memmap_tensor0] 55.7810μs 26.2696μs 38.0668 KOps/s 39.2322 KOps/s $\color{#d91a1a}-2.97\%$
test_add_one[memmap_tensor1] 0.2082ms 75.6714μs 13.2150 KOps/s 12.9447 KOps/s $\color{#35bf28}+2.09\%$
test_contiguous[memmap_tensor0] 31.0400μs 6.3183μs 158.2712 KOps/s 162.0069 KOps/s $\color{#d91a1a}-2.31\%$
test_contiguous[memmap_tensor1] 48.4510μs 23.1568μs 43.1839 KOps/s 43.4314 KOps/s $\color{#d91a1a}-0.57\%$
test_stack[memmap_tensor0] 50.3910μs 21.5629μs 46.3760 KOps/s 47.9920 KOps/s $\color{#d91a1a}-3.37\%$
test_stack[memmap_tensor1] 0.1633ms 77.0724μs 12.9748 KOps/s 13.0602 KOps/s $\color{#d91a1a}-0.65\%$
test_memmaptd_index 0.2975ms 0.2549ms 3.9225 KOps/s 3.8881 KOps/s $\color{#35bf28}+0.88\%$
test_memmaptd_index_astensor 0.3707ms 0.3122ms 3.2030 KOps/s 3.1594 KOps/s $\color{#35bf28}+1.38\%$
test_memmaptd_index_op 0.6718ms 0.6152ms 1.6256 KOps/s 1.6450 KOps/s $\color{#d91a1a}-1.18\%$
test_reshape_pytree 0.2556ms 21.7879μs 45.8971 KOps/s 47.6825 KOps/s $\color{#d91a1a}-3.74\%$
test_reshape_td 59.1810μs 32.1605μs 31.0940 KOps/s 32.5733 KOps/s $\color{#d91a1a}-4.54\%$
test_view_pytree 45.4100μs 21.3757μs 46.7820 KOps/s 47.6811 KOps/s $\color{#d91a1a}-1.89\%$
test_view_td 23.5900μs 4.1246μs 242.4481 KOps/s 244.0892 KOps/s $\color{#d91a1a}-0.67\%$
test_unbind_pytree 40.5400μs 26.3963μs 37.8841 KOps/s 37.9231 KOps/s $\color{#d91a1a}-0.10\%$
test_unbind_td 85.6210μs 60.2546μs 16.5963 KOps/s 16.9163 KOps/s $\color{#d91a1a}-1.89\%$
test_split_pytree 46.9210μs 25.1023μs 39.8370 KOps/s 39.7676 KOps/s $\color{#35bf28}+0.17\%$
test_split_td 76.3410μs 46.1943μs 21.6477 KOps/s 22.2985 KOps/s $\color{#d91a1a}-2.92\%$
test_add_pytree 52.4810μs 34.5098μs 28.9773 KOps/s 29.9516 KOps/s $\color{#d91a1a}-3.25\%$
test_add_td 78.9320μs 47.8048μs 20.9184 KOps/s 21.0041 KOps/s $\color{#d91a1a}-0.41\%$
test_distributed 18.1000μs 5.5634μs 179.7477 KOps/s 178.0469 KOps/s $\color{#35bf28}+0.96\%$
test_tdmodule 37.4010μs 17.1501μs 58.3089 KOps/s 59.2463 KOps/s $\color{#d91a1a}-1.58\%$
test_tdmodule_dispatch 0.1898ms 33.8931μs 29.5045 KOps/s 29.5810 KOps/s $\color{#d91a1a}-0.26\%$
test_tdseq 35.0900μs 20.2585μs 49.3619 KOps/s 49.7060 KOps/s $\color{#d91a1a}-0.69\%$
test_tdseq_dispatch 55.8110μs 37.2978μs 26.8112 KOps/s 26.7425 KOps/s $\color{#35bf28}+0.26\%$
test_instantiation_functorch 1.7694ms 1.7263ms 579.2891 Ops/s 592.2114 Ops/s $\color{#d91a1a}-2.18\%$
test_instantiation_td 1.6928ms 1.2055ms 829.5263 Ops/s 837.3210 Ops/s $\color{#d91a1a}-0.93\%$
test_exec_functorch 0.2065ms 0.1660ms 6.0227 KOps/s 6.0980 KOps/s $\color{#d91a1a}-1.23\%$
test_exec_functional_call 0.2102ms 0.1646ms 6.0749 KOps/s 6.0380 KOps/s $\color{#35bf28}+0.61\%$
test_exec_td 0.1921ms 0.1579ms 6.3318 KOps/s 6.3893 KOps/s $\color{#d91a1a}-0.90\%$
test_exec_td_decorator 64.6246ms 0.2143ms 4.6662 KOps/s 5.1111 KOps/s $\textbf{\color{#d91a1a}-8.71\%}$
test_vmap_mlp_speed[True-True] 1.1576ms 1.1016ms 907.7904 Ops/s 909.5661 Ops/s $\color{#d91a1a}-0.20\%$
test_vmap_mlp_speed[True-False] 0.6840ms 0.6264ms 1.5963 KOps/s 1.5920 KOps/s $\color{#35bf28}+0.27\%$
test_vmap_mlp_speed[False-True] 1.0654ms 1.0052ms 994.8679 Ops/s 995.6908 Ops/s $\color{#d91a1a}-0.08\%$
test_vmap_mlp_speed[False-False] 0.5974ms 0.5543ms 1.8042 KOps/s 1.7980 KOps/s $\color{#35bf28}+0.35\%$
test_vmap_mlp_speed_decorator[True-True] 2.6053ms 2.1021ms 475.7115 Ops/s 477.4607 Ops/s $\color{#d91a1a}-0.37\%$
test_vmap_mlp_speed_decorator[True-False] 1.0700ms 0.6688ms 1.4953 KOps/s 1.4815 KOps/s $\color{#35bf28}+0.93\%$
test_vmap_mlp_speed_decorator[False-True] 2.2855ms 1.8292ms 546.7003 Ops/s 548.2527 Ops/s $\color{#d91a1a}-0.28\%$
test_vmap_mlp_speed_decorator[False-False] 0.8725ms 0.5706ms 1.7525 KOps/s 1.7394 KOps/s $\color{#35bf28}+0.76\%$
test_vmap_transformer_speed[True-True] 13.0344ms 12.9366ms 77.3000 Ops/s 77.4581 Ops/s $\color{#d91a1a}-0.20\%$
test_vmap_transformer_speed[True-False] 13.6387ms 8.5106ms 117.5009 Ops/s 117.5067 Ops/s $-0.00\%$
test_vmap_transformer_speed[False-True] 12.9025ms 12.8394ms 77.8850 Ops/s 78.0283 Ops/s $\color{#d91a1a}-0.18\%$
test_vmap_transformer_speed[False-False] 8.4635ms 8.3816ms 119.3094 Ops/s 118.6036 Ops/s $\color{#35bf28}+0.60\%$
test_vmap_transformer_speed_decorator[True-True] 67.4221ms 66.6101ms 15.0127 Ops/s 15.0739 Ops/s $\color{#d91a1a}-0.41\%$
test_vmap_transformer_speed_decorator[True-False] 22.5267ms 20.4705ms 48.8509 Ops/s 48.4924 Ops/s $\color{#35bf28}+0.74\%$
test_vmap_transformer_speed_decorator[False-True] 61.7445ms 60.4678ms 16.5377 Ops/s 15.4233 Ops/s $\textbf{\color{#35bf28}+7.23\%}$
test_vmap_transformer_speed_decorator[False-False] 99.2476ms 21.7460ms 45.9854 Ops/s 49.6045 Ops/s $\textbf{\color{#d91a1a}-7.30\%}$

@vmoens vmoens marked this pull request as ready for review December 5, 2023 12:06
@vmoens vmoens merged commit d347869 into main Dec 5, 2023
45 checks passed
@vmoens vmoens added bug Something isn't working CI Test labels Dec 5, 2023
@vmoens vmoens deleted the fix-memmap-osx branch October 21, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants