Skip to content

Commit

Permalink
[Versioning] M1 compatibility (#523)
Browse files Browse the repository at this point in the history
  • Loading branch information
vmoens authored Oct 26, 2023
1 parent 6a9f8e3 commit e2de5ef
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/scripts/m1_script.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/bin/bash

export BUILD_VERSION=0.2.0
43 changes: 43 additions & 0 deletions .github/workflows/build-wheels-m1.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Build M1 Wheels

on:
pull_request:
push:
branches:
- nightly
- main
- release/*
tags:
# NOTE: Binary build pipelines should only get triggered on release candidate builds
# Release candidate tags look like: v1.11.0-rc1
- v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+
workflow_dispatch:

jobs:
generate-matrix:
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
with:
package-type: wheel
os: macos-arm64
test-infra-repository: pytorch/test-infra
test-infra-ref: main
build:
needs: generate-matrix
name: pytorch/tensordict
uses: pytorch/test-infra/.github/workflows/build_wheels_macos.yml@main
with:
repository: pytorch/tensordict
ref: ""
test-infra-repository: pytorch/test-infra
test-infra-ref: main
build-matrix: ${{ needs.generate-matrix.outputs.matrix }}
# pre-script: .github/scripts/pre_build_script_m1.sh
post-script: ""
package-name: tensordict
runner-type: macos-m1-12
smoke-test-script: ""
trigger-event: ${{ github.event_name }}
env-var-script: .github/scripts/m1_script.sh
secrets:
AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID: ${{ secrets.AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID }}
AWS_PYTORCH_UPLOADER_SECRET_ACCESS_KEY: ${{ secrets.AWS_PYTORCH_UPLOADER_SECRET_ACCESS_KEY }}

1 comment on commit e2de5ef

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'CPU Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e2de5ef Previous: 6a9f8e3 Ratio
benchmarks/common/common_ops_test.py::test_getitem[range] 5907.631296135694 iter/sec (stddev: 0.00011313076283935396) 12273.399836637294 iter/sec (stddev: 0.0000024274520622255505) 2.08
benchmarks/common/common_ops_test.py::test_getitem[list] 6454.485601943946 iter/sec (stddev: 0.00009993011056679118) 13026.398437738166 iter/sec (stddev: 0.00000427788044603234) 2.02
benchmarks/common/common_ops_test.py::test_setitem_dim[slice_int] 7611.917760491742 iter/sec (stddev: 0.0003105281474132736) 16189.485625140715 iter/sec (stddev: 0.0000026220719954638607) 2.13
benchmarks/common/memmap_benchmarks_test.py::test_add_one[memmap_tensor0] 14050.784320083547 iter/sec (stddev: 0.00004814404506843958) 29702.995992213757 iter/sec (stddev: 0.000026074768256202254) 2.11
benchmarks/common/memmap_benchmarks_test.py::test_stack[memmap_tensor0] 16914.406636840806 iter/sec (stddev: 0.00006893482736684527) 37002.6255684846 iter/sec (stddev: 0.0000014862119865061807) 2.19
benchmarks/common/memmap_benchmarks_test.py::test_memmaptd_index_op 184.0784972027477 iter/sec (stddev: 0.0007522187030068204) 375.5558718082069 iter/sec (stddev: 0.000019091399628856324) 2.04
benchmarks/nn/functional_benchmarks_test.py::test_exec_td 2510.468163777016 iter/sec (stddev: 0.0002610622473328803) 5214.390352153065 iter/sec (stddev: 0.000006677945799307712) 2.08

This comment was automatically generated by workflow using github-action-benchmark.

CC: @vmoens

Please sign in to comment.