Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate TSNodeLoweringInterface #78273

Closed
wants to merge 4 commits into from
Closed

Deprecate TSNodeLoweringInterface #78273

wants to merge 4 commits into from

Conversation

antoniojkim
Copy link
Collaborator

Fixes #78206

Deprecate TSNodeLoweringInterface and refactor lower functions into IR nodes.

CC: @wconstab @desertfire

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 25, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (6 Pending)

As of commit 2190d9a (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

JackCaoG
JackCaoG reviewed May 25, 2022
View reviewed changes
torch/csrc/lazy/backend/lowering_context.h Outdated
@@ -88,6 +88,8 @@ class TORCH_API LoweringContext {
const Shape& shape,
const std::string& name) = 0;

virtual void Lower(const Node*) = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will require a xla side change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this API really needs to be in lowering_context.h? It is not being used outside of lowering_context constructor, maybe we should just let backend to define this function instead of putting it in the base class?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a good point. I guess it doesn't need to be in the top level class.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although, it seems to be passing all the XLA tests. Unless you are referring to a change in a PR that is currently in progress

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merge pytorch/xla@185dd3c, which I think will be broken by this change. It is not a hard fix but I felt like maybe we don't need this class in the top level.

@antoniojkim antoniojkim force-pushed the antoniojkim/refactor_node_lowerings branch from 83d120b to dc68dcc Compare May 25, 2022 20:36
@antoniojkim antoniojkim force-pushed the antoniojkim/refactor_node_lowerings branch from dc68dcc to 2190d9a Compare May 26, 2022 20:06
@antoniojkim
Copy link
Collaborator Author

@wconstab @desertfire All tests green! Can I get a review for this please?

@dagitses dagitses requested a review from wconstab May 31, 2022 14:24
@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 31, 2022
wconstab
wconstab approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@wconstab wconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @antoniojkim

@antoniojkim
Copy link
Collaborator Author

@wconstab @desertfire Can we get the merge process started?

@wconstab
Copy link
Contributor

@wconstab @desertfire Can we get the merge process started?

you should be able to merge it yourself now, we have adopted a 'github first' merge process. you just write a comment saying "@pytorchbot merge this" and it gets done

@antoniojkim
Copy link
Collaborator Author

antoniojkim commented May 31, 2022 •
edited
Loading

you should be able to merge it yourself now, we have adopted a 'github first' merge process. you just write a comment saying "@pytorchbot merge this" and it gets done

Oh cool. Thanks!

@antoniojkim
Copy link
Collaborator Author

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @antoniojkim.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 1, 2022
@antoniojkim @facebook-github-bot
Deprecate TSNodeLoweringInterface (#78273) (#78273)
3a9eec3 
Summary:
Fixes #78206

Deprecate `TSNodeLoweringInterface` and refactor lower functions into IR nodes.

GitHub CC:
wconstab desertfire

Pull Request resolved: #78273
Approved by: https://github.com/wconstab

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/fe67dff82abf883dfb3623757dda6dab4dd848b7

Reviewed By: seemethere

Differential Revision: D36815082

Pulled By: seemethere

fbshipit-source-id: a9531f9d4f379e717b5e9298ada7b1020afb7da2
@antoniojkim antoniojkim mentioned this pull request Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackCaoG JackCaoG JackCaoG left review comments

@wconstab wconstab wconstab approved these changes

Assignees

@wconstab wconstab

Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate TSNodeLoweringInterface
7 participants
@antoniojkim @facebook-github-bot @wconstab @JackCaoG @dagitses @pytorchbot @pytorchmergebot