Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meta func for scaled mm #112609

Closed
wants to merge 6 commits into from
Closed

Add meta func for scaled mm #112609

wants to merge 6 commits into from
+95 −2

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Nov 1, 2023 •
edited by pytorch-bot bot
Loading

Summary

Adds a meta implementation for _scaled_mm which is required for dynamic shapes

cc @yanbing-j @vkuzo @albanD @kadeng

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 1, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112609

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit cca6cfe with merge base fb0e3a5 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison
eellison approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - can you make sure there are opinfo inputs if there arent already ?

torch/_meta_registrations.py Outdated Show resolved Hide resolved
torch/_meta_registrations.py Outdated Show resolved Hide resolved
torch/_meta_registrations.py Show resolved Hide resolved
torch/_meta_registrations.py Show resolved Hide resolved
@drisspg drisspg added release notes: Meta API release notes category topic: not user facing topic category module: float8 For torch.float8_e5m2 and torch.float8_e4m3 labels Nov 1, 2023
@drisspg
Copy link
Contributor Author

drisspg commented Nov 2, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 2, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Nov 2, 2023

@pytorchbot revert -m 'Sorry for reverting this change, but it is failing ROCm jobs https://hud.pytorch.org/pytorch/pytorch/commit/75174c379712433af1ff810b36e34573b3d2587e' -c nosignal

We are having capacity issue with ROCm runner, so ROCm jobs are only run in trunk atm. I will add ciflow/rocm to run the jobs on your PR

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@drisspg your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Nov 2, 2023
@pytorchmergebot
Revert "Add meta func for scaled mm (#112609)"
2e29172 
This reverts commit 75174c3.

Reverted #112609 on behalf of https://github.com/huydhn due to Sorry for reverting this change, but it is failing ROCm jobs https://hud.pytorch.org/pytorch/pytorch/commit/75174c379712433af1ff810b36e34573b3d2587e ([comment](#112609 (comment)))
@drisspg
Copy link
Contributor Author

drisspg commented Nov 3, 2023

@huydhn no worries, I imagine that I just need to add one more decorator to the op info, but will wait for CI to confirm

@drisspg
Copy link
Contributor Author

drisspg commented Nov 3, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-test / test

Details for Dev Infra team Raised by workflow job

@huydhn
Copy link
Contributor

huydhn commented Nov 3, 2023

Just FYI, the binary build failure is unrelated and comes from pytorch/builder#1578 (comment), so that should be safe to bypass

@drisspg
Copy link
Contributor Author

drisspg commented Nov 3, 2023

@pytorchbot merge -f "unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@chenyang78 chenyang78 mentioned this pull request Nov 3, 2023
Closed
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@drisspg @xuhancn
Add meta func for scaled mm (pytorch#112609)
9c8f57e 
# Summary
Adds a meta implementation for _scaled_mm which is required for dynamic shapes

Pull Request resolved: pytorch#112609
Approved by: https://github.com/eellison, https://github.com/malfet
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@pytorchmergebot @xuhancn
Revert "Add meta func for scaled mm (pytorch#112609)"
41d2a95 
This reverts commit 75174c3.

Reverted pytorch#112609 on behalf of https://github.com/huydhn due to Sorry for reverting this change, but it is failing ROCm jobs https://hud.pytorch.org/pytorch/pytorch/commit/75174c379712433af1ff810b36e34573b3d2587e ([comment](pytorch#112609 (comment)))
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@drisspg @xuhancn
Add meta func for scaled mm (pytorch#112609)
acd787e 
# Summary
Adds a meta implementation for _scaled_mm which is required for dynamic shapes

Pull Request resolved: pytorch#112609
Approved by: https://github.com/eellison, https://github.com/malfet
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@drisspg @Skylion007
Add meta func for scaled mm (pytorch#112609)
61483f4 
# Summary
Adds a meta implementation for _scaled_mm which is required for dynamic shapes

Pull Request resolved: pytorch#112609
Approved by: https://github.com/eellison, https://github.com/malfet
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@pytorchmergebot @Skylion007
Revert "Add meta func for scaled mm (pytorch#112609)"
60e702a 
This reverts commit 75174c3.

Reverted pytorch#112609 on behalf of https://github.com/huydhn due to Sorry for reverting this change, but it is failing ROCm jobs https://hud.pytorch.org/pytorch/pytorch/commit/75174c379712433af1ff810b36e34573b3d2587e ([comment](pytorch#112609 (comment)))
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@drisspg @Skylion007
Add meta func for scaled mm (pytorch#112609)
1489979 
# Summary
Adds a meta implementation for _scaled_mm which is required for dynamic shapes

Pull Request resolved: pytorch#112609
Approved by: https://github.com/eellison, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

@malfet malfet malfet approved these changes

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@ngimel ngimel Awaiting requested review from ngimel

Assignees
No one assigned
Labels
ciflow/rocm ciflow/trunk Trigger trunk jobs on your pull request Merged module: float8 For torch.float8_e5m2 and torch.float8_e4m3 release notes: Meta API release notes category Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drisspg @pytorchmergebot @huydhn @malfet @eellison