Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade ruby version, lockfile #1816

Merged
merged 11 commits into from
Nov 26, 2024
Merged

upgrade ruby version, lockfile #1816

merged 11 commits into from
Nov 26, 2024

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Nov 16, 2024

https://deploy-preview-1816--pytorch-dot-org-preview.netlify.app/edge

Ruby Version Upgrade:

  • Updated the Ruby version from 2.7.8 to 3.3.0 in .ruby-version and Gemfile. [1] [2] - this kills most of the security warnings we have on this repo

Documentation Updates:

  • Changed code block language identifiers to bash in README.md and updated the bundler version to 2.5.23. [1] [2]

EDIT: Discussed this a bit more with @cjyabraham and opted to revert the edge related doc changes

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for pytorch-dot-org-preview ready!

Name Link
🔨 Latest commit f070c8b
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/674643b2524b6e0008c268e2
😎 Deploy Preview https://deploy-preview-1816--pytorch-dot-org-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@svekars
Copy link
Collaborator

svekars commented Nov 18, 2024

I disagree that we should delete the edge.html page without giving it more thought . If it is decided to be deprecated, it needs to be replaced with a redirect to other relevant page. Also, the whole Edge dropdown with just 1 item won't make a lot of sense.

@msaroufim
Copy link
Member Author

msaroufim commented Nov 26, 2024

I chatted with @ali-khosh offline and he said he'd fine with this change if I can guarantee that the redirects are working which they are!

@msaroufim msaroufim requested a review from cjyabraham November 26, 2024 19:28
@msaroufim
Copy link
Member Author

@cjyabraham planning on merging this tomorrow, lmk if you have any objections?

edge.html Outdated
</div>


redirect_to: /executorch-overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that this thing is called .html, while it's clearly not :)

@ali-khosh
Copy link

I disagree that we should delete the edge.html page without giving it more thought . If it is decided to be deprecated, it needs to be replaced with a redirect to other relevant page. Also, the whole Edge dropdown with just 1 item won't make a lot of sense.

Also, I believe the dropdown would disappear as well (per preview I'm seeing). Also @svekars for context, we're "archiving" this for now since PyTorch Edge's only offering atm is ExecuTorch. We'll likely resurrect this umbrella page once we have more edge libraries.

Copy link
Collaborator

@cjyabraham cjyabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, however, you'll also need to update _includes/mobile_menu.html so that it matches your changes to main_menu.html.

@jennbly
Copy link
Collaborator

jennbly commented Nov 26, 2024

I'd suggest that we not have an option in the middle of the drop down menu without a drop down. Could we instead move to under "Ecosystem" or "Learn"?

@msaroufim
Copy link
Member Author

msaroufim commented Nov 26, 2024

Looks ok, however, you'll also need to update _includes/mobile_menu.html so that it matches your changes to main_menu.html.

@cjyabraham can you take a look again please?

I'd suggest that we not have an option in the middle of the drop down menu without a drop down. Could we instead move to under "Ecosystem" or "Learn"?

@jennbly that's probably a better fit for a future PR, the site does need some more changes to make the flow clearer and I think I'll get more pushback removing the top level Edge drop menu since it's a nice advertisement spot. EDIT: Thought about this a bit more and you're right, especially on mobile this made the site very ugly

@cjyabraham
Copy link
Collaborator

Looks ok, however, you'll also need to update _includes/mobile_menu.html so that it matches your changes to main_menu.html.

can you take a look again please?

The mobile menu still doesn't match with the desktop menu.

BTW, why not put the "Edge" menu item under the "Learn" menu or some other menu rather than have it standing by itself?

@@ -67,9 +67,6 @@
<a>Edge</a>
</li>
<ul class="resources-mobile-menu-items">
<li>
Copy link
Member Author

@msaroufim msaroufim Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjyabraham not 100% sure I follow but was this not what you were asking about to make the mobile_menu match?

@msaroufim msaroufim requested a review from cjyabraham November 26, 2024 21:54
@cjyabraham cjyabraham changed the title upgrade ruby version, lockfile and edge blog upgrade ruby version, lockfile Nov 26, 2024
@cjyabraham cjyabraham merged commit fd50d96 into site Nov 26, 2024
4 of 5 checks passed
@ali-khosh
Copy link

ali-khosh commented Nov 26, 2024

BTW, why not put the "Edge" menu item under the "Learn" menu or some other menu rather than have it standing by itself?
Edge is a key strategic bet and we'd like to keep it more visible.
Thought about this a bit more and you're right, especially on mobile this made the site very ugly
Don't know what it looks but if the mobile still doesn't match the desktop menu, maybe we can have Edge as header and ExecuTorch as sub menu just for mobile? Or not change it on mobile at all? Honestly I don't think we get many people to navigate to these on mobile and as Mark mentioned there are bigger issues around IA/navigation than this for mobile anyways.

@cjyabraham
Copy link
Collaborator

I'm having trouble running the site locally on MacOS after this upgrade. I've upgraded ruby, however, I'm now getting this: https://gist.github.com/cjyabraham/5f12926a985e77acb986bc70f4bd7125

Any advice?

@msaroufim
Copy link
Member Author

Managed to repro locally after running this

rm -rf vendor/
rm Gemfile.lock
bundle install
make serve

Gimme a few minutes to look into this, if it's too hard we can revert this PR

msaroufim added a commit that referenced this pull request Nov 27, 2024
cjyabraham pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants