Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torch compile row to pytorch install table #1762

Open
wants to merge 3 commits into
base: site
Choose a base branch
from

Conversation

suryasidd
Copy link

Proposal to enhance torch.compile onboarding by adding installation instructions on the PyTorch main page:

Currently, there is no visibility of torch compile backends on the Pytorch main page. Developers looking to use torch.compile with a specific backend must navigate through multiple steps: they first consult the torch.compile documentation, then visit individual backend documentation pages to understand installation requirements. This process adds unnecessary friction, especially for those just getting started with torch.compile

We propose adding a dedicated torch.compile row to the Install Table on the PyTorch main page. Given the high traffic on this page, this change would streamline this process for developers. By clicking on the desired backend, developers will be provided with simple installation and usage command making it easier for them to get started.

Sample webpage: https://suryasidd.github.io/pytorch.github.io/

Copy link

CLA Not Signed

Copy link

netlify bot commented Oct 9, 2024

👷 Deploy Preview for pytorch-dot-org-preview processing.

Name Link
🔨 Latest commit c888989
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/6705de5ed9f7010008e37724

@suryasidd
Copy link
Author

Hi, I'm not sure if we need to make the changes to the script in https://github.com/pytorch/test-infra/blob/main/.github/workflows/generate_binary_build_matrix.yml instead of modifying the js files directly. Please advise

@agunapal
Copy link

agunapal commented Nov 4, 2024

cc @svekars

@kit1980
Copy link
Member

kit1980 commented Nov 4, 2024

@suryasidd please sign the CLA

@atalman
Copy link
Contributor

atalman commented Nov 4, 2024

Hi @suryasidd the getting started page is already quite complex. We probably don't want to make it even more complex by adding torch.compile section to it. Maybe this can be designed as separate page ?

@agunapal
Copy link

agunapal commented Nov 4, 2024

@suryasidd I agree with @atalman . Also, torch.compile is one of the technologies. If we add this, then it would open up possibilities for other technologies as well, making the page even more complex.

@suryasidd
Copy link
Author

I understand. Would it be possible to add a section for torch.compile in the main page and then link it to the torch.compiler docs page ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants