Create dummymodule _C instead of using load_library(blah.so) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janeyx99
commented
Jan 23, 2025
janeyx99
changed the title
…static initializers
zou3519
reviewed
Jan 24, 2025
setup.py
Outdated
| @@ -38,6 +38,7 @@ def get_extensions(): | |||
| "cxx": [ | |||
| "-O3" if not debug_mode else "-O0", | |||
| "-fdiagnostics-color=always", | |||
| "-DPy_LIMITED_API=0x03090000", | |||
There was a problem hiding this comment.
maybe a comment here about python 3.9
zou3519
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussions from the tutorials change, the consensus was to:
THE QUESTION IS: do we prefer this approach over the torch.ops.load_library(so_file) approach?
This was tested locally -- tests pass and the wheel is CPython agnostic.