Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: create build_variables.bzl #8326

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WIP: create build_variables.bzl #8326

wants to merge 2 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 8, 2025

First step of #8268.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 8, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Feb 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8326

Note: Links to docs will display an error until the docs builds have been completed.

❌ 33 New Failures

As of commit bc3fd39 with merge base 513e92d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 8, 2025
swolchok added a commit that referenced this pull request Feb 8, 2025
First step of #8268.

ghstack-source-id: b29aa49a24776718804c64e66340b3d1a954e1e1
ghstack-comment-id: 2644414497
Pull Request resolved: #8326
@swolchok swolchok marked this pull request as draft February 8, 2025 01:37
Copy link

github-actions bot commented Feb 8, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 9, 2025
First step of #8268 -- we are moving from buck-extracted filelist to using one shared filelist, and the first step is to create the shared filelist and validate it against the buck generation.

ghstack-source-id: 07b627bb84e9bc101aaa56f37f3430e89ddcc615
ghstack-comment-id: 2644414497
Pull Request resolved: #8326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants