s/IF_FALSE/UNLESS/ in ET_LOG macro names #8317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8317
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 8ee2441 with merge base 883d33a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 7, 2025
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Feb 7, 2025
"do something unless X" reads much better than "do something if false X". ghstack-source-id: cae2fe0bf74e32e72179b3288bb610c1ae252afa ghstack-comment-id: 2644043544 Pull Request resolved: #8317
dbort
approved these changes
Feb 8, 2025
| do { \ | ||
| if (!(cond)) { \ | ||
| ET_LOG(Error, "Check failed (%s): ", #cond); \ | ||
| return false; \ | ||
| } \ | ||
| } while (false) | ||
|
|
||
| /** | ||
| * Backward compatibility shim for the old name of ET_LOG_AND_RETURN_UNLESS. |
There was a problem hiding this comment.
Suggested change
| * Backward compatibility shim for the old name of ET_LOG_AND_RETURN_UNLESS. | |
| * DEPRECATED: Please use ET_LOG_AND_RETURN_UNLESS instead. |
| do { \ | ||
| if (!(cond)) { \ | ||
| ET_LOG(Error, "Check failed (%s): " message, #cond, ##__VA_ARGS__); \ | ||
| return false; \ | ||
| } \ | ||
| } while (false) | ||
|
|
||
| /** | ||
| * Backward compatibility shim for the old name of ET_LOG_MSG_AND_RETURN_UNLESS |
There was a problem hiding this comment.
Suggested change
| * Backward compatibility shim for the old name of ET_LOG_MSG_AND_RETURN_UNLESS | |
| * DEPRECATED: Please use ET_LOG_MSG_AND_RETURN_UNLESS instead. |
| @@ -338,14 +338,19 @@ | |||
| * | |||
| * @param[in] cond the condition to check | |||
| */ | |||
| #define ET_LOG_AND_RETURN_IF_FALSE(cond) \ | |||
| #define ET_LOG_AND_RETURN_UNLESS(cond) \ | |||
There was a problem hiding this comment.
These feel like they should live near
executorch/runtime/core/error.h
Line 121 in d99970b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"do something unless X" reads much better than "do something if false X".