Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oss qnn bug fix #8304

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

billmguo
Copy link
Contributor

@billmguo billmguo commented Feb 7, 2025

Summary:

  1. the graph actually include the torch.ops.aten.silu.default not the torch.nn.functional.silu
  2. the aten.mul.tensor is arg is scalar, this could apply to other ops

Differential Revision: D69286388

Copy link

pytorch-bot bot commented Feb 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8304

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit a5717e9 with merge base 57891b7 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69286388

@billmguo
Copy link
Contributor Author

billmguo commented Feb 7, 2025

@pytorchbot label "topic: not user facing"

Copy link
Collaborator

@haowhsu-quic haowhsu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Summary:
pytorch#8304
1. the graph actually include the torch.ops.aten.silu.default not the torch.nn.functional.silu
2. the aten.mul.tensor is arg is scalar, this could apply to other ops

Differential Revision: D69286388
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69286388

@limintang limintang self-requested a review February 10, 2025 21:38
@facebook-github-bot facebook-github-bot merged commit 8e3f060 into pytorch:main Feb 10, 2025
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants