Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Half/BFloat16 in upsample_bilinear2d #7910

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Support Half/BFloat16 in upsample_bilinear2d #7910

merged 1 commit into from
Jan 28, 2025

Conversation

swolchok
Copy link
Contributor

Partial fix for #7748.

@swolchok
Update
924968c 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 23, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7910

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 924968c with merge base 70f9b5d (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2025
swolchok added a commit that referenced this pull request Jan 23, 2025
@swolchok
Support Half/BFloat16 in upsmple_bilinear2d
b40492f 
Partial fix for #7748.

ghstack-source-id: 5b09712d9327c0fab6c32d64e3b94ecc57f0271a
ghstack-comment-id: 2611090027
Pull Request resolved: #7910
@swolchok swolchok requested a review from GregoryComer January 23, 2025 21:51
@swolchok swolchok changed the title Support Half/BFloat16 in upsmple_bilinear2d Support Half/BFloat16 in upsample_bilinear2d Jan 23, 2025
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 23, 2025
@swolchok swolchok requested a review from kirklandsign January 23, 2025 21:53
@swolchok swolchok mentioned this pull request Jan 23, 2025
Merged
@swolchok
Copy link
Contributor Author

confirmed mac unittest failure looks unrelated

@swolchok swolchok merged commit 58bda89 into main Jan 28, 2025
44 of 47 checks passed
@swolchok swolchok deleted the gh/swolchok/197/head branch January 28, 2025 16:30
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
Support Half/BFloat16 in upsample_bilinear2d (#7910)
cad2d0f 
Partial fix for #7748.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
Support Half/BFloat16 in upsample_bilinear2d (pytorch#7910)
457b5a8 
Partial fix for pytorch#7748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @manuelcandales @facebook-github-bot