Support BFloat16 in full_like #7822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7822
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9cc8669 with merge base 1655fc5 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added
the
release notes: ops & kernels
manuelcandales
requested changes
Jan 22, 2025
kernels/test/op_full_like_test.cpp
Outdated
| @@ -87,7 +87,7 @@ void OpFullLikeTest::test_full_like_out<ScalarType::Bool>() { | |||
|
|
|||
| TEST_F(OpFullLikeTest, AllRealOutputPasses) { | |||
| #define TEST_ENTRY(ctype, dtype) test_full_like_out<ScalarType::dtype>(); | |||
| ET_FORALL_REAL_TYPES_AND(Bool, TEST_ENTRY); | |||
| ET_FORALL_REALHBF16_TYPES(TEST_ENTRY); | |||
There was a problem hiding this comment.
Missing the boolean. Use ET_FORALL_REALHBBF16_TYPES. Granted that the test name was misleading. Could you please change that as well. AllRealOutputPasses -> AllDtypeOutputPasses
manuelcandales
approved these changes
Jan 23, 2025
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Partial fix for pytorch#7748.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #7748.