Add example of maml training on omniglot #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krovatkin
previously approved these changes
Apr 8, 2021
this is probably the highest density of optimizers per 10 LOCs, I've seen O_o
|
@Krovatkin It's been a while since you initially reviewed this PR. I rebased on top of the master branch and the build+tests now fully succeed. Could I ask you to take another look at this please before I hit the merge button? |
xuzhao9
reviewed
May 25, 2021
This is related to pytorch#328. This PR adds an actually correct implementation of maml to the repo. The previous implementation doesn't actually compute higher order gradients where it is supposed to. I'm not familiar with how torchbench works so please let me know if there are additional files that need to be modified. Test Plan: Ran the following: ``` python test.py -k test_maml_omniglot_example_cpu python test.py -k test_maml_omniglot_eval_cpu python test.py -k test_maml_omniglot_train_cpu ``` Future work: - Delete the maml example that is currently in this repo (or rename it to make it clear that it's doing something different from the paper that it is trying to reproduce).
zou3519
requested review from
xuzhao9 and
Krovatkin
and removed request for
Chillee
|
Please help resolve the comments and I will be happy to merge your contribution! |
|
@xuzhao9 I resolved the comments, could you please take another look when you get a chance? |
xuzhao9
approved these changes
May 27, 2021
zou3519
added a commit
to zou3519/benchmark
that referenced
this pull request
Sep 21, 2022
Fixes pytorch#328 Here's some context: - We discovered that the implementation doesn't actually use maml (dragen1860/MAML-Pytorch#59) - We filed pytorch#328 - We added maml_omniglot pytorch#349 as the correct version of of the maml model. - We didn't delete the maml model (because I was worried that it was doing a "different" type of maml that I hadn't seen before that is still valid). The last step to resolve this issue is to delete the incorrect MAML example, unless we have reasons to keep it around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #328. This PR adds an actually correct
implementation of maml to the repo. The previous implementation doesn't
actually compute higher order gradients where it is supposed to.
I'm not familiar with how torchbench works so please let me know if
there are additional files that need to be modified.
Test Plan:
Ran the following:
Future work:
to make it clear that it's doing something different from the paper that
it is trying to reproduce).