Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] do not run float8 tests if only docs changed #1591

Closed
wants to merge 2 commits into from

Conversation

danielvegamyhre
Copy link
Contributor

Part of #1524

Do not run float8 tests if only files in docs/** changed.

@danielvegamyhre danielvegamyhre added ci topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) labels Jan 21, 2025
Copy link

pytorch-bot bot commented Jan 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1591

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 986d718 with merge base 32d9b0b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2025
@danielvegamyhre danielvegamyhre requested a review from vkuzo January 21, 2025 20:12
@danielvegamyhre
Copy link
Contributor Author

Closing after discussion w/ Vasiliy on selective tests for float8, doesn't add enough value to justify extra CI script complexity here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants