Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support aten.diagonal converter #2856

Merged
merged 3 commits into from
May 30, 2024
Merged

feat: support aten.diagonal converter #2856

merged 3 commits into from
May 30, 2024

Conversation

chohk88
Copy link
Collaborator

@chohk88 chohk88 commented May 22, 2024 •
edited
Loading

Description

A converter for the torch.ops.aten.diagonal operation. There are very good reference for aten.diagonal operation ( https://github.com/pytorch/pytorch/blob/082251e76b93b277ff2791d0e2b64934add34644/torch/_refs/__init__.py#L4255 )

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@chohk88 chohk88 added the component: converters Issues re: Specific op converters label May 22, 2024
@chohk88 chohk88 self-assigned this May 22, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels May 22, 2024
@github-actions github-actions bot requested a review from peri044 May 22, 2024 13:33
zewenli98
zewenli98 reviewed May 23, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just added some comments for your reference.

py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py Outdated Show resolved Hide resolved
zewenli98
zewenli98 approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chohk88 chohk88 merged commit 2cc80d8 into main May 30, 2024
49 of 51 checks passed
This was linked to issues May 31, 2024
aten.diagonal #2873
Closed
↔ [Converter] Add support for aten.diagonal #2846
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zewenli98 zewenli98 zewenli98 approved these changes

@apbose apbose Awaiting requested review from apbose

@gs-olive gs-olive Awaiting requested review from gs-olive

@peri044 peri044 Awaiting requested review from peri044

Assignees

@chohk88 chohk88

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aten.diagonal ↔ [Converter] Add support for aten.diagonal
3 participants
@chohk88 @zewenli98 @facebook-github-bot