Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-10 GA Support for main branch #2781

Merged
merged 8 commits into from
Apr 29, 2024
Merged

Conversation

zewenli98
Copy link
Collaborator

Description

This PR runs CI to test TRT-10 GA support for main branch.

@zewenli98 zewenli98 self-assigned this Apr 26, 2024
@github-actions github-actions bot added component: build system Issues re: Build system component: api [Python] Issues re: Python API labels Apr 26, 2024
@github-actions github-actions bot requested a review from peri044 April 26, 2024 03:02
@zewenli98 zewenli98 added WIP Work is in progress, pull request should not be merged yet component: build system Issues re: Build system component: api [Python] Issues re: Python API cla signed and removed component: build system Issues re: Build system component: api [Python] Issues re: Python API cla signed labels Apr 26, 2024
@zewenli98 zewenli98 removed the request for review from peri044 April 26, 2024 03:07
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zewenli98 zewenli98 requested a review from peri044 April 26, 2024 18:54
@zewenli98 zewenli98 changed the title [WIP] TRT-10 GA Support for main branch TRT-10 GA Support for main branch Apr 26, 2024
@zewenli98 zewenli98 removed the WIP Work is in progress, pull request should not be merged yet label Apr 26, 2024
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. pending rebase

dev_dep_versions.yml Outdated Show resolved Hide resolved
py/requirements.txt Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@HolyWu
Copy link
Contributor

HolyWu commented Apr 27, 2024

"tensorrt",
also needs to specify version.

@zewenli98
Copy link
Collaborator Author

@HolyWu Made the changes. Thanks for the review!

dev_dep_versions.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the component: tests Issues re: Tests label Apr 29, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_dyn_models.py	2024-04-29 19:55:18.604129+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_dyn_models.py	2024-04-29 19:57:14.310783+00:00
@@ -7,13 +7,11 @@
from torch_tensorrt.dynamo.utils import COSINE_THRESHOLD, cosine_similarity

assertions = unittest.TestCase()


-@unittest.skip(
-    "Skipping this test for now due to a bug"
-)
+@unittest.skip("Skipping this test for now due to a bug")
@pytest.mark.unit
def test_base_dynamic(ir):
    """
    Tests the model (which is fully convertible) with dynamic shapes
    """
@@ -67,13 +65,11 @@

    with torch.no_grad():
        torch.cuda.empty_cache()


-@unittest.skip(
-    "Skipping this test for now due to a bug"
-)
+@unittest.skip("Skipping this test for now due to a bug")
@pytest.mark.unit
def test_base_dynamic_fallback(ir):
    """
    Tests the model with dynamic shapes where torch.abs op is forced to run in PyTorch
    """

@zewenli98 zewenli98 merged commit 482206f into main Apr 29, 2024
7 checks passed
laikhtewari pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants