Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TS Add converter support for aten::grid_sampler #2717

Merged

Conversation

mfeliz-cruise
Copy link
Contributor

Description

Adds converter support for aten::grid_sampler in the TorchScript frontend. https://pytorch.org/docs/stable/generated/torch.nn.functional.grid_sample.html

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters labels Mar 26, 2024
@github-actions github-actions bot requested a review from peri044 March 26, 2024 23:31
@mfeliz-cruise mfeliz-cruise force-pushed the michael.feliz/aten_grid_sampler branch from 2fe72e5 to 7a16c48 Compare March 26, 2024 23:35
@mfeliz-cruise mfeliz-cruise changed the title [feat] TS: Add converter support for aten::grid_sampler feat: TS Add converter support for aten::grid_sampler Mar 26, 2024
Copy link
Collaborator

@bowang007 bowang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit e90d070 into pytorch:main Apr 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants