Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fix: Parse out slashes in Docker container name #2437

Merged
merged 1 commit into from
Nov 6, 2023
Merged

minor fix: Parse out slashes in Docker container name #2437

merged 1 commit into from
Nov 6, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Nov 6, 2023

Description

  • Removes forward slashes from container names to avoid issues with tags and naming

Type of change

  • GHA fix

Checklist:

  • [ - ] My code follows the style guidelines of this project (You can use the linters)
  • [ - ] I have performed a self-review of my own code
  • [ - ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ - ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
  • [ - ] New and existing unit tests pass locally with my changes
  • [ - ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this Nov 6, 2023
@gs-olive gs-olive force-pushed the docker_builder_container_name_parsing branch from b9509df to d52956f Compare November 6, 2023 19:56
github-actions[bot]
github-actions bot approved these changes Nov 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@gs-olive gs-olive force-pushed the docker_builder_container_name_parsing branch from d52956f to b1cefb9 Compare November 6, 2023 19:59
@gs-olive
Copy link
Collaborator Author

gs-olive commented Nov 6, 2023

Manually verified in GHA

github-actions[bot]
github-actions bot approved these changes Nov 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive merged commit 6f6bec2 into main Nov 6, 2023
7 checks passed
@gs-olive gs-olive deleted the docker_builder_container_name_parsing branch November 6, 2023 19:59
github-actions[bot]
github-actions bot approved these changes Nov 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Nov 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

gs-olive added a commit that referenced this pull request Nov 6, 2023
@gs-olive
minor fix: Parse out slashes in Docker container name (#2437)
acad3db
@gs-olive gs-olive mentioned this pull request Nov 6, 2023
Merged
gs-olive added a commit that referenced this pull request Nov 6, 2023
@gs-olive
cherry-pick/minor fix: Parse out slashes in Docker container name (#2437
42f87f2 
) (#2438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gs-olive @facebook-github-bot