Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add support for default dimension in aten.cat #1863

Merged
merged 1 commit into from
May 24, 2023
Merged

fix: Add support for default dimension in aten.cat #1863

merged 1 commit into from
May 24, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Apr 27, 2023 •
edited
Loading

Description

  • Add default dim=0 to concatenation operator for use cases which do not have a specific concatenation dimension specified
  • T5 encounters this error during compilation
  • Add test cases to elicit error with default dimension

Fixes #1862
Addresses #1740

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive requested a review from frank-wei April 27, 2023 17:02
@gs-olive gs-olive self-assigned this Apr 27, 2023
@github-actions github-actions bot requested a review from wushirong April 27, 2023 17:02
@gs-olive
fix: Add support for default dimension in aten.cat
2237eeb 
- Add default `dim=0` to concatenation operator for use cases which do
not have a specific concatenation dimension specified
- T5 encounters this error during compilation
- Add test cases to elicit error with default dimension
@gs-olive gs-olive requested a review from frank-wei May 23, 2023 01:56
frank-wei
frank-wei approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@frank-wei frank-wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gs-olive gs-olive merged commit de79be6 into pytorch:main May 24, 2023
@gs-olive gs-olive deleted the aten_cat_default_dim_fix branch May 24, 2023 16:32
gs-olive added a commit that referenced this pull request May 26, 2023
@gs-olive
fix: Add support for default dimension in aten.cat (#1863)
91d48b8
@gs-olive gs-olive mentioned this pull request May 26, 2023
Merged
narendasan pushed a commit that referenced this pull request May 30, 2023
@gs-olive @narendasan
fix: Add support for default dimension in aten.cat (#1863)
f5133eb
narendasan pushed a commit that referenced this pull request Jun 2, 2023
@gs-olive @narendasan
fix: Add support for default dimension in aten.cat (#1863)
db0b82a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frank-wei frank-wei frank-wei approved these changes

@wushirong wushirong Awaiting requested review from wushirong

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: fx fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Encountered bug when using torch.ops.aten.cat converter
3 participants
@gs-olive @frank-wei @facebook-github-bot