Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add converter for aten::isfinite #1841

Merged
merged 1 commit into from
May 30, 2023

Conversation

mfeliz-cruise
Copy link
Contributor

@mfeliz-cruise mfeliz-cruise commented Apr 20, 2023

Description

Adds a converter to support aten::isfinite https://pytorch.org/docs/stable/generated/torch.isfinite.html.

Implemented as (x-x)==(x-x). Relies on the fact that x-x = NaN for NaN, inf and -inf and NaN != NaN.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Apr 20, 2023
@github-actions github-actions bot requested a review from peri044 April 20, 2023 00:44
@peri044
Copy link
Collaborator

peri044 commented May 24, 2023

@narendasan can you merge this ? I still don't have permissions.

@narendasan narendasan merged commit 6d28bba into pytorch:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants