Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Implement aten.mean.default and aten.mean.dim converters #1810

Merged
merged 1 commit into from
Apr 21, 2023
Merged

fix: Implement aten.mean.default and aten.mean.dim converters #1810

merged 1 commit into from
Apr 21, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Apr 6, 2023 •
edited
Loading

Description

  • Replace existing implementation of aten.mean.dim with general version invoking centralized add_reduce_layer utility
  • Add implementation of aten.mean.default by refactoring default case to be a special invocation of aten.mean.dim (specifically, one with dim being all dimensions in the Tensor and keepdim being False).
  • Add defaults for optional arguments in converters
  • Add test cases for combinations of input options to the converters

Fixes #1742
Addresses First Bug in #1740

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this Apr 6, 2023
@github-actions github-actions bot requested a review from yinghai April 6, 2023 22:53
@gs-olive
fix: Implement aten.mean.default + aten.mean.dim converters
2347441 
- Replace existing implementation of aten.mean.dim with general version
invoking centralized `add_reduce_layer` utility
- Add implementation of aten.mean.default by refactoring default case to
be a special invocation of aten.mean.dim (specifically, one with `dim`
being all dimensions in the Tensor and `keepdim` being False).
- Add defaults for optional arguments in converters
- Add test cases for combinations of input options to the converters
@gs-olive
Copy link
Collaborator Author

gs-olive commented Apr 18, 2023 •
edited
Loading

Removed dependency on other PR, made this a standalone converter addition. @wushirong @frank-wei

narendasan
narendasan approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

frank-wei
frank-wei approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@frank-wei frank-wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@gs-olive gs-olive merged commit b3f433a into pytorch:main Apr 21, 2023
@gs-olive gs-olive deleted the aten_mean_converter branch April 21, 2023 20:40
bowang007 pushed a commit that referenced this pull request Apr 28, 2023
@gs-olive @bowang007
fix: Implement aten.mean.default and aten.mean.dim converters (#1810
71f61c6 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frank-wei frank-wei frank-wei approved these changes

@narendasan narendasan narendasan approved these changes

@apbose apbose Awaiting requested review from apbose

@yinghai yinghai Awaiting requested review from yinghai

@wushirong wushirong Awaiting requested review from wushirong

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: fx fx priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] aten.mean.dim converter throws error despite being supported
4 participants
@gs-olive @narendasan @frank-wei @facebook-github-bot