feat: Add decorator utility to improve error messaging for legacy support #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
narendasan
reviewed
Mar 15, 2023
gs-olive
force-pushed
the
function_decorator
branch
2 times, most recently
from
80d52fe
to
1b03650
Compare
gs-olive
commented
Mar 15, 2023
Comment on lines
+131
to
+134
| raise AssertionError( | ||
| f"Expected Torch version {min_torch_version} or greater, " | ||
| + f"when calling {f}. Detected version {torch.__version__}" | ||
| ) |
There was a problem hiding this comment.
The function f is printed in the error message, which includes its name.
- Add general-purpose utility for intercepting invalid Torch version imports and displaying an error message to the user, halting compilation - Utility automatically parses string inputs to semantic versions using the `packaging` utility package - Decorator can accept variable input versions and checks whether the current version in use in the environment is at least as large as the minimum specified version - Display clear error message upon calling the aten tracer when using a legacy Torch version, for which the Dynamo import is invalid
gs-olive
force-pushed
the
function_decorator
branch
from
1b03650
to
a4efe09
Compare
gs-olive
commented
Mar 15, 2023
| @@ -104,3 +105,36 @@ def f(*inp): | |||
| mod = run_const_fold(mod) | |||
| mod = replace_op_with_indices(mod) | |||
| return mod | |||
|
|
|||
|
|
|||
| def req_torch_version(min_torch_version: str = "2.dev"): | |||
There was a problem hiding this comment.
Default is "2.dev" since "2.0" is considered to be a larger version than "2.0.0.dev____".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1733
Type of change
Checklist: