Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add functionality for easily benchmarking fx code on key models #1506

Merged
merged 1 commit into from
Dec 4, 2022
Merged

feat: Add functionality for easily benchmarking fx code on key models #1506

merged 1 commit into from
Dec 4, 2022

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Dec 1, 2022

Description

  • Add fx path in benchmarking code
  • Add fx saving tools to utils and hub
  • Add PyTorch model parsing and loading in perf_run script

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
    • Manually tested in Docker container
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive requested a review from peri044 December 1, 2022 16:26
peri044
peri044 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question below. Rest looks good.

tools/perf/hub.py Outdated Show resolved Hide resolved
@gs-olive
feat: Add functionality for easily benchmarking fx
2b130ec 
- Add fx path in benchmarking code
- Add fx saving tools to `utils` and `hub`
- Add PyTorch model parsing and loading in `perf_run` script
@peri044 peri044 merged commit 7cf6a4e into pytorch:master Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @peri044 @facebook-github-bot