-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix missing float type in shape analysis #1399
Conversation
Signed-off-by: Bo Wang <[email protected]>
Signed-off-by: Dheeraj Peri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Can you rebase this with latest master so that the CI tests update accordingly ?
Signed-off-by: Dheeraj Peri <[email protected]>
Signed-off-by: Dheeraj Peri <[email protected]>
chore: minor fixes
Signed-off-by: Torch-TensorRT Github Bot <[email protected]>
…#1395) * Augment current tests to reproduce error generating bug with standard dev / variance lowering * fix: Ensure torch.std (and torch.var) support multiple dimensions - Refactor IR code to avoid the use of select, for which only single-dimension support exists currently - Update formula in Bessel's correction (unbiased) case - Include regression tests to catch multi-dimensional indexing errors * Improved comments on IR for UnpackVar function
Signed-off-by: Torch-TensorRT Github Bot <[email protected]>
Signed-off-by: Bo Wang <[email protected]>
…into fix_missing_type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
rebased. |
Signed-off-by: Bo Wang [email protected]
Description
Fixes missing type error.
Fixes #1378
Type of change
Checklist: