Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing float type in shape analysis #1399

Merged
merged 10 commits into from
Oct 12, 2022
Merged

Conversation

bowang007
Copy link
Collaborator

Signed-off-by: Bo Wang [email protected]

Description

Fixes missing type error.

Fixes #1378

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

bowang007 and others added 2 commits October 6, 2022 01:19
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can you rebase this with latest master so that the CI tests update accordingly ?

peri044 and others added 8 commits October 11, 2022 15:03
Signed-off-by: Dheeraj Peri <[email protected]>
…#1395)

* Augment current tests to reproduce error generating bug with standard dev / variance lowering

* fix: Ensure torch.std (and torch.var) support multiple dimensions

- Refactor IR code to avoid the use of select, for which only
single-dimension support exists currently
- Update formula in Bessel's correction (unbiased) case
- Include regression tests to catch multi-dimensional indexing errors

* Improved comments on IR for UnpackVar function
@github-actions github-actions bot added component: build system Issues re: Build system component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests documentation Improvements or additions to documentation labels Oct 12, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@bowang007
Copy link
Collaborator Author

LGTM. Can you rebase this with latest master so that the CI tests update accordingly ?

rebased.

@peri044 peri044 merged commit bb75932 into master Oct 12, 2022
@bowang007 bowang007 deleted the fix_missing_type branch October 13, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: build system Issues re: Build system component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: partitioning component: tests Issues re: Tests documentation Improvements or additions to documentation
Projects
None yet
4 participants