minimize functions defined in headers #836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D33358916 |
jspark1105
added a commit
to jspark1105/FBGEMM
that referenced
this pull request
Dec 30, 2021
Summary: Pull Request resolved: pytorch#836 We had so much stuffs that didn't need to be at header files. Split long source files. Put experimental quantization functions to experimental namespace Differential Revision: D33358916 fbshipit-source-id: b979802f9eaa5d42d0b5806c371df39c9fda6d45
jspark1105
force-pushed
the
export-D33358916
branch
from
6fa30b6
to
ddfccc0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33358916 |
Summary: Pull Request resolved: pytorch#836 We had so much stuffs that didn't need to be at header files. Split long source files. Put experimental quantization functions to experimental namespace Differential Revision: D33358916 fbshipit-source-id: ecc2c6bb33879092f40837a88450d327b86e236f
|
This pull request was exported from Phabricator. Differential Revision: D33358916 |
jspark1105
force-pushed
the
export-D33358916
branch
from
ddfccc0
to
0e5a79c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We had so much stuffs that didn't need to be at header files.
Split long source files.
Put experimental quantization functions to experimental namespace
Differential Revision: D33358916