-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove NOT rocm check from gen_ai compile #3126
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -104,11 +104,6 @@ if(NOT FBGEMM_CPU_ONLY) | |||
add_subdirectory(experimental/gemm) | |||
endif() | |||
|
|||
if(NOT FBGEMM_CPU_ONLY AND NOT USE_ROCM) | |||
# CUTLASS currently doesn't build on ROCm and CK hasnt yet been added: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is no longer an issue right?
Please rebase and we'll do the import |
@acoskunses-AMD : Looks like the OSS tests show building errors: https://github.com/pytorch/FBGEMM/actions/runs/10963754353/job/30445890513?pr=3126
|
fae63ec
to
0d8dff8
Compare
rebased please review. @jianyuh for compile issue I need to file another PR you might want to merge that one first |
@acoskunses-AMD which PR is that? |
I take this back, it seems CK has mentioned headers, with tip of tree things compile. Maybe CI has an older CK version? |
Enable rocm gen_ai compile by removing NOT Rocm check.
Mentioned cutlass hipify issue resolved via PR #2965