Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix set_cuda arg mismatch issue #3089

Closed
wants to merge 1 commit into from
+9 −5
Closed

fix set_cuda arg mismatch issue #3089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions fbgemm_gpu/src/ps_split_embeddings_cache/ps_split_table_batched_embeddings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,21 @@ class EmbeddingParameterServerWrapper : public torch::jit::CustomClassHolder {
max_D);
}

void
set_cuda(Tensor indices, Tensor weights, Tensor count, int64_t timestep) {
return impl_->set_cuda(indices, weights, count, timestep);
void set_cuda(
Tensor indices,
Tensor weights,
Tensor count,
int64_t timestep,
bool is_bwd = false) {
return impl_->set_cuda(indices, weights, count, timestep, is_bwd);
}

void get_cuda(Tensor indices, Tensor weights, Tensor count) {
return impl_->get_cuda(indices, weights, count);
}

void set(Tensor indices, Tensor weights, Tensor count) {
return impl_->set(indices, weights, count);
void set(Tensor indices, Tensor weights, Tensor count, bool is_bwd = false) {
return impl_->set(indices, weights, count, is_bwd);
}

void get(Tensor indices, Tensor weights, Tensor count) {
Expand Down