Work around offsets and indices type mismatch int TBE training #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D61801695 |
…ch#3037) Summary: X-link: facebookresearch/FBGEMM#135 Pull Request resolved: pytorch#3037 D61524189 added `bounds_check_indices` in the `prefetch` function. It expects `indices` and `offsets` to have the same type. However, that is not always the case. This diff forces type casting on `indices` and `offsets` if they do not have the same type. A long term solution is to update `bounds_check_indices` to support `indices` and `offsets` that have different types. Reviewed By: PaulZhang12 Differential Revision: D61801695
|
This pull request was exported from Phabricator. Differential Revision: D61801695 |
sryap
force-pushed
the
export-D61801695
branch
from
bc7b8e0
to
324888f
Compare
|
This pull request has been merged in e782781. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D61524189 added
bounds_check_indicesin theprefetchfunction. Itexpects
indicesandoffsetsto have the same type. However, thatis not always the case. This diff forces type casting on
indicesand
offsetsif they do not have the same type. A long term solutionis to update
bounds_check_indicesto supportindicesandoffsetsthat have different types.
Reviewed By: PaulZhang12
Differential Revision: D61801695