Fix get_unique_indices_v2 registration #2993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D61294287 |
|
This pull request was exported from Phabricator. Differential Revision: D61294287 |
sryap
force-pushed
the
export-D61294287
branch
from
7391569 to
0d89feb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61294287 |
sryap
force-pushed
the
export-D61294287
branch
from
0d89feb to
720f379
Compare
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Aug 15, 2024
Summary: X-link: facebookresearch/FBGEMM#85 Pull Request resolved: pytorch#2993 Properly register `get_unique_indices_v2` in `torch.ops.fbgemm` and import it in SSD-TBE. - Use `init` to define and register each op only once - Check if an op is defined before defining and registering it to avoid duplicate declaration Reviewed By: q10 Differential Revision: D61294287
Summary: X-link: facebookresearch/FBGEMM#85 Pull Request resolved: pytorch#2993 Remove `get_unique_indices_v2` registration in `torch.ops.fbgemm` as we cannot cleanly/safely register it Reviewed By: q10 Differential Revision: D61294287
|
This pull request was exported from Phabricator. Differential Revision: D61294287 |
sryap
force-pushed
the
export-D61294287
branch
from
720f379 to
94e7157
Compare
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Aug 15, 2024
Summary: X-link: facebookresearch/FBGEMM#85 Pull Request resolved: pytorch#2993 Remove `get_unique_indices_v2` registration in `torch.ops.fbgemm` as we cannot cleanly/safely register it Reviewed By: q10 Differential Revision: D61294287
|
This pull request has been merged in 160633c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Properly register
get_unique_indices_v2intorch.ops.fbgemmandimport it in SSD-TBE.
initto define and register each op only onceavoid duplicate declaration
Differential Revision: D61294287